Modify getting Metaflow version #2009
Conversation
Favors reading the INFO file if present to be able to have the most accurate version of Metaflow when executing remotely (especially in the presence of extensions). Also limit reading the INFO file to once per process (as opposed to possibly twice). Finally, gets the version of the source of Metaflow (and not the current directory)
romain-intel
force-pushed
the
fix/version-info
branch
from
6d619e3
to
2201f4e
Compare
There was a problem hiding this comment.
seems like this change doesn't quite work for our current set of extensions. @madhur-ob can you help triage what might be going wrong?
metaflow/__init__.py
Outdated
| ext_version = _format_git_describe( | ||
| _call_git_describe(cwd=os.path.dirname(extension_module.__file__)) | ||
| ) | ||
| if ext_version is None: |
There was a problem hiding this comment.
shouldn't this be the other way around?
also, i am getting Metaflow 2.12.18.post5-git2201f4e-dirty+ob(4.3.19) executing... - the interesting thing is that we don't have version 4.3.19 for any extensions internally. we pin the extension version explicitly to v1. it's likely that git describe --tags is the offender here.
There was a problem hiding this comment.
@madhur-ob do you happen to know how ob releases are git tagged?
There was a problem hiding this comment.
I think the order is correct here:
- look for GIT version first (ie: if we are in a GIT repo)
- if not, look at the version field
I am not sure how you are getting the 4.3.19 indeed. This should be coming from the git_describe call that was previously used (and I did not change the logic of this) so I do suspect you are not tagging in a "normal" way.
This reverts commit 0434e97.
* Add installed_extensions information This adds information to the system tags about the metaflow extensions that are installed. This makes it easier to reproduce the exact same environment. Information about whether the package information is complete or not is also included. This PR also fixes some issues with extension loading and allows extension information to be gathered in a programatic fashion thereby enabling the discovery of extensions. * Allow users to configure where extensions are searched * Move EXTENSIONS_SEARCH_DIRS out of config * Move the extension installation information to _graph_info
romain-intel
dismissed
savingoyal’s stale review
Savin confirmed this looked good offline.
Favors reading the INFO file if present to be able to have the most accurate version of Metaflow when executing remotely (especially in the presence of extensions).
Also limit reading the INFO file to once per process (as opposed to possibly twice).
Finally, gets the version of the source of Metaflow (and not the current directory)