Support for state override parameter in some RPC methods #7362

alexb5dh · 2024-08-26T05:48:51Z

Resolves #4021, resolves #6120, resolves #7306.

Changes

Support for state override set in the following RPC methods:
- eth_call, eth_estimategas
- trace_call
- debug_traceCall
Fixes double-serialization of some of the parameters in the RPC tests.
Makes trace_call, trace_callMany, and trace_rawTransaction to run on top of the specified block, instead of the previous one, similar to other clients.

What types of changes does your code introduce?

New feature (a non-breaking change that adds functionality)

Testing

Requires testing

Yes

If yes, did you write tests?

Yes

Documentation

Requires documentation update

Yes

Requires explanation in Release Notes

Yes, RPC changes should probably be included.

…verride # Conflicts: # src/Nethermind/Nethermind.Consensus/Processing/BlockProcessor.cs

src/Nethermind/Nethermind.JsonRpc/Modules/Trace/TraceRpcModule.cs

src/Nethermind/Nethermind.Evm/StateOverridesExtensions.cs

src/Nethermind/Nethermind.Facade/Eth/TransactionForRpc.cs

alexb5dh · 2024-10-03T05:50:02Z

src/Nethermind/Nethermind.Trie/Pruning/OverlayTrieStore.cs

@@ -24,4 +23,7 @@ public override TrieNode FindCachedOrUnknown(Hash256? address, in TreePath path,

 public override byte[]? TryLoadRlp(Hash256? address, in TreePath path, Hash256 hash, ReadFlags flags = ReadFlags.None) =>
 base.TryLoadRlp(address, in path, hash, flags) ?? store.TryLoadRlp(address, in path, hash, flags);
+
+ // TODO clarify is ClearCache is reliable enough to use
+ public void ResetOverrides() => ClearCache();


Comment on top of ClearCache says that it's added "to support testing", but it seems like a good way to reset state-override changes applied on top of OverlayTrieStore.

src/Nethermind/Nethermind.State/OverridableWorldStateManager.cs

…ntation

…verride

This reverts commit 15f0e39.

…verride

alexb5dh · 2024-10-05T19:39:11Z

src/Nethermind/Nethermind.Evm/StateOverridesExtensions.cs

 IReleaseSpec currentSpec,
 AccountOverride accountOverride,
 Address address)
 {
 if (accountOverride.Code is not null)
 {
+ stateProvider.InsertCode(address, accountOverride.Code, currentSpec);


This is needed to prevent an "Account {address} is null when updating storage hash" error in StateProvider when overridden code writes to address storage.

@OlegJakushkin maybe this solves some issues on StateRoot in eth_simulate?

…verride # Conflicts: # src/Nethermind/Nethermind.Evm/OverridableCodeInfoRepository.cs

LukaszRozmej

I think it would be good to separate ReadOnlyTxProcessingEnv with OverridableTxProcessingEnv instead of changing the first.
That double test serialization was also changed in different PR Avoid double serialization in RPC tests #7547

LukaszRozmej · 2024-10-09T12:31:23Z

src/Nethermind/Nethermind.Api/NethermindApi.cs

@@ -76,10 +76,11 @@ public NethermindApi(IConfigProvider configProvider, IJsonSerializer jsonSeriali
 public IBlockchainBridge CreateBlockchainBridge()
 {
 ReadOnlyBlockTree readOnlyTree = BlockTree!.AsReadOnly();
+ OverridableWorldStateManager overridableWorldStateManager = new(DbProvider!, WorldStateManager!.TrieStore, LogManager);

 // TODO: reuse the same trie cache here
 ReadOnlyTxProcessingEnv readOnlyTxProcessingEnv = new(


Maybe let's create OverridableTxProcessingEnv?

LukaszRozmej · 2024-10-09T12:31:56Z

src/Nethermind/Nethermind.Consensus/Processing/ReadOnlyTxProcessingScope.cs

@@ -2,12 +2,14 @@
 // SPDX-License-Identifier: LGPL-3.0-only

 using Nethermind.Core.Crypto;
+using Nethermind.Evm;
 using Nethermind.Evm.TransactionProcessing;
 using Nethermind.State;

 namespace Nethermind.Consensus.Processing;

 public class ReadOnlyTxProcessingScope(


maybe move to OverridableTxProcessingScope?

LukaszRozmej · 2024-10-09T12:34:15Z

src/Nethermind/Nethermind.Evm/StateOverridesExtensions.cs

 IReleaseSpec currentSpec,
 AccountOverride accountOverride,
 Address address)
 {
 if (accountOverride.Code is not null)
 {
+ stateProvider.InsertCode(address, accountOverride.Code, currentSpec);


@OlegJakushkin maybe this solves some issues on StateRoot in eth_simulate?

src/Nethermind/Nethermind.Facade/IBlockchainBridge.cs

LukaszRozmej · 2024-10-09T12:40:17Z

src/Nethermind/Nethermind.State/OverlayWorldStateManager.cs

+ ITrieStore trieStore = overlayTrieStore;
+ if ((forWarmup as IPreBlockCaches)?.Caches is { } preBlockCaches)
+ trieStore = new PreCachedTrieStore(trieStore, preBlockCaches.RlpCache);


Suggested change

ITrieStore trieStore = overlayTrieStore;

if ((forWarmup as IPreBlockCaches)?.Caches is { } preBlockCaches)

trieStore = new PreCachedTrieStore(trieStore, preBlockCaches.RlpCache);

ITrieStore trieStore = (forWarmup as IPreBlockCaches)?.Caches is { } preBlockCaches ? new PreCachedTrieStore(trieStore, preBlockCaches.RlpCache) : overlayTrieStore;

trieStore will be undefined in new PreCachedTrieStore(trieStore, preBlockCaches.RlpCache)

… instead of previous one

…verride

src/Nethermind/Nethermind.JsonRpc/Modules/Trace/TraceRpcModule.cs

…eader & fix starting block for `trace_callMany`

…verride

alexb5dh added 9 commits August 20, 2024 20:31

Moved OverridableCodeInfoRepository to Nethermind.Evm

8c5f8ee

Made state commit optional during overrides

5343927

Allow state overrides for eth_call, eth_estimategas

d97caa4

Allow state overrides for trace_call, trace_callMany

264056f

Simplify eth_* overriding code

3c19b09

Fix double serialization in RPC tests

aeaf7f0

Code cleanup

c8fa006

Merge remote-tracking branch 'origin/master' into feature/rpc-state-o…

37eb5e3

…verride # Conflicts: # src/Nethermind/Nethermind.Consensus/Processing/BlockProcessor.cs

Allow state overrides for debug_traceCall

9a7094d

alexb5dh self-assigned this Aug 26, 2024

alexb5dh commented Aug 26, 2024

View reviewed changes

src/Nethermind/Nethermind.JsonRpc/Modules/Trace/TraceRpcModule.cs Show resolved Hide resolved

alexb5dh commented Aug 26, 2024

View reviewed changes

src/Nethermind/Nethermind.Evm/StateOverridesExtensions.cs Outdated Show resolved Hide resolved

alexb5dh requested review from OlegJakushkin and LukaszRozmej August 26, 2024 06:19

alexb5dh added 2 commits September 1, 2024 03:53

Update supported methods to match Reth version

94c2618

Added missing tests

eb3700a

alexb5dh force-pushed the feature/rpc-state-override branch from 6cb949c to 00aae73 Compare September 1, 2024 00:55

alexb5dh added 4 commits September 3, 2024 03:08

Normalize block error

58886b6

Tests fixes

76eea55

Adjust insufficient-balance handling when simulating transaction

1dee3c0

Fix chain-id missing in one of the RPC transaction conversions

363fdc9

alexb5dh force-pushed the feature/rpc-state-override branch from 00aae73 to 363fdc9 Compare September 3, 2024 10:56

alexb5dh added 8 commits September 4, 2024 03:44

Fix for Eth_call_with_accessList test

51d6aa6

State overrides for eth_call using SimulateTxExecutor

3e5f964

State overrides for eth_estimateGas using OverridableWorldState

4de78ab

Adjusted eth_estimateGas test values

3e1d83a

Simplify changes

18825c8

Use custom OverridableWorldStateManager

d900a5a

Simplify changes

95fb2ed

eth_estimateGas test improvements

b4df9a7

Code cleanup

5bf6c58

alexb5dh commented Oct 3, 2024

View reviewed changes

src/Nethermind/Nethermind.Facade/Eth/TransactionForRpc.cs Show resolved Hide resolved

alexb5dh commented Oct 3, 2024

View reviewed changes

Revert unneeded changes

bd28e70

alexb5dh force-pushed the feature/rpc-state-override branch from bfa7dc9 to bd28e70 Compare October 3, 2024 05:56

alexb5dh added 9 commits October 3, 2024 09:01

Use IOverridableCodeInfoRepository interface instead of the impleme…

a1bd302

…ntation

Merge remote-tracking branch 'origin/master' into feature/rpc-state-o…

f8d8137

…verride

Get rid of NotSupportedException

15f0e39

Revert "Get rid of NotSupportedException"

f05b7d2

This reverts commit 15f0e39.

Simplify tests

cc3cb4c

Update trace_call overrides tests

82d7345

Fix for "Account is null when updating storage hash" on code override

df1e146

[WIP] State overrides for trace_call using OverridableWorldState

e35f7e4

Merge remote-tracking branch 'origin/master' into feature/rpc-state-o…

c902a07

…verride

alexb5dh commented Oct 5, 2024

View reviewed changes

Code cleanup

d4f75c5

LukaszRozmej mentioned this pull request Oct 7, 2024

6662 debug trace call many #7441

Draft

15 tasks

Merge remote-tracking branch 'origin/master' into feature/rpc-state-o…

8b2bb68

…verride # Conflicts: # src/Nethermind/Nethermind.Evm/OverridableCodeInfoRepository.cs

LukaszRozmej reviewed Oct 9, 2024

View reviewed changes

alexb5dh added 3 commits October 9, 2024 22:54

Change trace_call and trace_rawTransaction to use specified block…

606b569

… instead of previous one

Test fix

3c3f6b0

Merge remote-tracking branch 'origin/master' into feature/rpc-state-o…

dc9de8e

…verride

alexb5dh force-pushed the feature/rpc-state-override branch from 79f571c to 4cca8a2 Compare October 11, 2024 05:15

Code cleanup

eba8bf0

alexb5dh force-pushed the feature/rpc-state-override branch from 4cca8a2 to eba8bf0 Compare October 11, 2024 05:19

alexb5dh commented Oct 11, 2024

View reviewed changes

src/Nethermind/Nethermind.JsonRpc/Modules/Trace/TraceRpcModule.cs Outdated Show resolved Hide resolved

alexb5dh added 4 commits October 11, 2024 22:33

Fix unit tests

4ee4658

Switch to ProcessingOptions.ForceState instead of generating fake h…

9c0244b

…eader & fix starting block for `trace_callMany`

Rename ForceState to ForceSameBlock

023ab9c

Merge remote-tracking branch 'origin/master' into feature/rpc-state-o…

d01cf9c

…verride

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for state override parameter in some RPC methods #7362

Support for state override parameter in some RPC methods #7362

alexb5dh commented Aug 26, 2024 •

edited

Loading

alexb5dh Oct 3, 2024 •

edited

Loading

alexb5dh Oct 5, 2024 •

edited

Loading

LukaszRozmej Oct 9, 2024

LukaszRozmej left a comment

LukaszRozmej Oct 9, 2024

LukaszRozmej Oct 9, 2024

LukaszRozmej Oct 9, 2024

LukaszRozmej Oct 9, 2024

alexb5dh Oct 11, 2024

Support for state override parameter in some RPC methods #7362

Are you sure you want to change the base?

Support for state override parameter in some RPC methods #7362

Conversation

alexb5dh commented Aug 26, 2024 • edited Loading

Changes

What types of changes does your code introduce?

Testing

Requires testing

If yes, did you write tests?

Documentation

Requires documentation update

Requires explanation in Release Notes

alexb5dh Oct 3, 2024 • edited Loading

Choose a reason for hiding this comment

alexb5dh Oct 5, 2024 • edited Loading

Choose a reason for hiding this comment

LukaszRozmej Oct 9, 2024

Choose a reason for hiding this comment

LukaszRozmej left a comment

Choose a reason for hiding this comment

LukaszRozmej Oct 9, 2024

Choose a reason for hiding this comment

LukaszRozmej Oct 9, 2024

Choose a reason for hiding this comment

LukaszRozmej Oct 9, 2024

Choose a reason for hiding this comment

LukaszRozmej Oct 9, 2024

Choose a reason for hiding this comment

alexb5dh Oct 11, 2024

Choose a reason for hiding this comment

alexb5dh commented Aug 26, 2024 •

edited

Loading

alexb5dh Oct 3, 2024 •

edited

Loading

alexb5dh Oct 5, 2024 •

edited

Loading