6662 debug trace call many #7441
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@MarekM25 does this look good for the debug_traceCallMany functionality? |
|
@smartprogrammer93 @LukaszRozmej requesting your review on this. |
LukaszRozmej
requested changes
Oct 7, 2024
| @@ -33,6 +33,9 @@ public interface IDebugRpcModule : IRpcModule | |||
| [JsonRpcMethod(Description = "This method lets you run an eth_call within the context of the given block execution using the final state of parent block as the base. The block can be specified either by hash or by number. It takes the same input object as a eth_call. It returns the same output as debug_traceTransaction.", IsImplemented = true, IsSharable = true)] | |||
| ResultWrapper<GethLikeTxTrace> debug_traceCall(TransactionForRpc call, BlockParameter? blockParameter = null, GethTraceOptions? options = null); | |||
|
|
|||
| [JsonRpcMethod(Description = "This method lets you run trace_callMany for a list of transactions.It doesn't charge fees. It returns a list of Trace objects.", IsImplemented = true, IsSharable = true)] | |||
There was a problem hiding this comment.
Not sure about the description. @rubo ?
| txs[i] = tx; | ||
| } | ||
|
|
||
| Block block = new(headerSearch.Object!, txs, Enumerable.Empty<BlockHeader>()); |
There was a problem hiding this comment.
This block is constructed but never used?
Comment on lines
+98
to
+117
| SearchResult<BlockHeader> headerSearch = _debugBridge.SearchBlockHeaderForTraceCall(blockParameter); | ||
| if (headerSearch.IsError) | ||
| { | ||
| return ResultWrapper<IEnumerable<GethLikeTxTrace>>.Fail(headerSearch); | ||
| } | ||
|
|
||
| if (!_debugBridge.HasStateForBlock(headerSearch.Object)) | ||
| { | ||
| return ResultWrapper<IEnumerable<GethLikeTxTrace>>.Fail($"No state available for block {headerSearch.Object.ToString(BlockHeader.Format.FullHashAndNumber)}", ErrorCodes.ResourceUnavailable); | ||
| } | ||
|
|
||
| Dictionary<Hash256, ParityTraceTypes> traceTypeByTransaction = new(calls.Length); | ||
| Transaction[] txs = new Transaction[calls.Length]; | ||
| for (int i = 0; i < calls.Length; i++) | ||
| { | ||
| calls[i].Transaction.EnsureDefaults(_jsonRpcConfig.GasCap); | ||
| Transaction tx = calls[i].Transaction.ToTransaction(); | ||
| tx.Hash = new Hash256(new UInt256((ulong)i).ToBigEndian()); | ||
| txs[i] = tx; | ||
| } |
There was a problem hiding this comment.
All logic should live in GethStyleTracer
There was a problem hiding this comment.
Hey, I'm sorry but I didn't understand what you meant here. Did you mean using GethStyleTracer instead of GethLikeTrace as object?
| return ResultWrapper<IEnumerable<GethLikeTxTrace>>.Fail($"No state available for block {headerSearch.Object.ToString(BlockHeader.Format.FullHashAndNumber)}", ErrorCodes.ResourceUnavailable); | ||
| } | ||
|
|
||
| Dictionary<Hash256, ParityTraceTypes> traceTypeByTransaction = new(calls.Length); |
There was a problem hiding this comment.
ParityTraceType's have no sense in Geth style tracing (debug module)
| @@ -33,6 +33,9 @@ public interface IDebugRpcModule : IRpcModule | |||
| [JsonRpcMethod(Description = "This method lets you run an eth_call within the context of the given block execution using the final state of parent block as the base. The block can be specified either by hash or by number. It takes the same input object as a eth_call. It returns the same output as debug_traceTransaction.", IsImplemented = true, IsSharable = true)] | |||
| ResultWrapper<GethLikeTxTrace> debug_traceCall(TransactionForRpc call, BlockParameter? blockParameter = null, GethTraceOptions? options = null); | |||
|
|
|||
| [JsonRpcMethod(Description = "This method lets you run trace_callMany for a list of transactions.It doesn't charge fees. It returns a list of Trace objects.", IsImplemented = true, IsSharable = true)] | |||
| ResultWrapper<IEnumerable<GethLikeTxTrace>> debug_traceCallMany(TransactionForRpcWithTraceTypes[] calls, BlockParameter? blockParameter = null); | |||
There was a problem hiding this comment.
I think the signature should be different: https://www.chainnodes.org/docs/ethereum/debug_traceCallMany
For overrides, please wait for this PR: #7362
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6662
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs. Remove if not applicable.Requires explanation in Release Notes
If yes, fill in the details here. Remove if not applicable.