glog: disable broken test under clang

[tobim]

Description of changes

google/glog#937

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 23.11 Release Notes (or backporting 23.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

[r-burns]

Unfortunately I think even more failing tests have come up since I last looked at this. With doCheck = true on x86_64-darwin, I see failures in logging_custom_prefix, logging, and mock-log.

[tobim]

The latest version of the patch disables the ones you mentioned explicitly now, can you check again?

[r-burns]

Unlike ctest -E, looks like the GTEST_FILTER needs the specific test case name:

Suggested change

	"logging_custom_prefix"
	"logging"
	"mock-log"
	"LogBacktraceAt.DoesBacktraceAtRightLineWhenEnabled"

And mock-log seems to be segfaulting at init so unfortunately I think we would need a separate mechanism to disable that test file entirely, such as ctest -E as is done here

With LogBacktraceAt.DoesBacktraceAtRightLineWhenEnabled and mock-log disabled, all the remaining tests pass for me on x86_64-darwin

[tobim]

Thanks, I implemented the exclusion according to your recommendation.

[tobim]

I added a workaround to a broken glogConfig.cmake installation with the latest commit.

[r-burns]

Looks good! Tested and working on x86_64-darwin. Sorry about all that ctest nonsense.

[vcunat]

Some of the tests crash on *-darwin now:
https://hydra.nixos.org/build/232481702/nixlog/2/tail

[tobim]

Too bad. I guess we'll have to disable again.

[tjni]

I don't know if this is the best way to disable the tests, but it suffices to skip them locally on my aarch64-darwin machine: #251729. I'm happy to iterate on this to make this better moving forward!