Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

glog: disable logging tests on aarch64-darwin #251729

Merged
merged 1 commit into from
Aug 27, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 27, 2023

Description of changes

This is the failure on Hydra:

[ RUN      ] SafeFNMatch.logging
[       OK ] SafeFNMatch.logging (0 ms)
[----------] 1 test from SafeFNMatch (0 ms total)

[----------] 1 test from Strerror
[ RUN      ] Strerror.logging
[       OK ] Strerror.logging (0 ms)
[----------] 1 test from Strerror (0 ms total)

[----------] 2 tests from DVLog
[ RUN      ] DVLog.Basic
[       OK ] DVLog.Basic (0 ms)
[ RUN      ] DVLog.V0

      Start  4: signalhandler
 4/16 Test  #4: signalhandler ....................   Passed    0.17 sec
      Start  5: stacktrace
 5/16 Test  #5: stacktrace .......................   Passed    0.16 sec
      Start  6: stl_logging
 6/16 Test  #6: stl_logging ......................   Passed    0.15 sec
      Start  7: symbolize
 7/16 Test  #7: symbolize ........................   Passed    0.14 sec
      Start  8: cmake_package_config_init
 8/16 Test  #8: cmake_package_config_init ........   Passed    0.03 sec
      Start  9: cmake_package_config_generate
 9/16 Test  #9: cmake_package_config_generate ....   Passed    0.45 sec
      Start 10: cmake_package_config_build
10/16 Test #10: cmake_package_config_build .......   Passed    0.49 sec
      Start 11: cmake_package_config_cleanup
11/16 Test #11: cmake_package_config_cleanup .....   Passed    0.01 sec
      Start 12: cleanup_init
12/16 Test #12: cleanup_init .....................   Passed    0.01 sec
      Start 14: cleanup_immediately
13/16 Test #14: cleanup_immediately ..............   Passed    3.29 sec
      Start 15: cleanup_with_absolute_prefix
14/16 Test #15: cleanup_with_absolute_prefix .....   Passed    3.34 sec
      Start 16: cleanup_with_relative_prefix
15/16 Test #16: cleanup_with_relative_prefix .....   Passed    6.35 sec
      Start 13: cleanup_logdir
16/16 Test #13: cleanup_logdir ...................   Passed    0.02 sec

88% tests passed, 2 tests failed out of 16

Total Test time (real) =  15.49 sec

The following tests FAILED:
          1 - logging_custom_prefix (SEGFAULT)
          3 - logging (SEGFAULT)
Errors while running CTest

Apologies that this might not be the best way to disable the test, but I couldn't figure out how to get the filter to work. This should suffice to get this package and its dependents to pass on staging-next (#250778) right now, so I'd like to merge it as is. Happy to iterate on this and apply any feedback.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandbox = true set in nix.conf? (See Nix manual)
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 23.11 Release Notes (or backporting 23.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@tjni tjni mentioned this pull request Aug 27, 2023
12 tasks
@K900 K900 merged commit 6330827 into NixOS:staging-next Aug 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants