Exclude project references with ReferenceOutputAssembly=false #1352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sual Studio restore Projects with ReferenceOutputAssembly=false should be ignored during restore in Visual Studio. Transitive dependencies should not flow from these projects to the parent project. Fixes NuGet/Home#4992
emgarten
requested review from
rohit21agrawal,
nkolev92,
zhili1208,
alpaix,
mishra14 and
jainaashish
|
looks good. but why does this only happen from the VS Auto Restore? in other words, why isn't this a part of the common VS and CLI restore code path? |
rohit21agrawal
approved these changes
May 1, 2017
|
@rohit21agrawal this deals with how the inputs are collected. From VS it is sent to NuGet by the project system using a push model. From the command line we read it ourselves using MSBuild. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exclude project references with ReferenceOutputAssembly=false from Visual Studio restore
Projects with ReferenceOutputAssembly=false should be ignored during restore in Visual Studio. Transitive dependencies should not flow from these projects to the parent project.
I've tested this manually. I don't see a clear way to add unit tests for this without refactoring or making these private methods public which doesn't appear to go with the current design.
Fixes NuGet/Home#4992