Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude project references with ReferenceOutputAssembly=false #1352

Merged
merged 1 commit into from
May 2, 2017
Merged

Exclude project references with ReferenceOutputAssembly=false #1352

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/NuGet.Clients/NuGet.SolutionRestoreManager/VsSolutionRestoreService.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,7 @@ private static ProjectRestoreMetadataFrameworkInfo ToProjectRestoreMetadataFrame
tfi.ProjectReferences.AddRange(
targetFrameworkInfo.ProjectReferences
.Cast<IVsReferenceItem>()
.Where(IsReferenceOutputAssemblyTrueOrEmpty)
.Select(item => ToProjectRestoreReference(item, projectDirectory)));
}

Expand Down Expand Up @@ -452,5 +453,16 @@ private static string GetPropertyValueOrNull(

return null;
}

/// <summary>
/// True if ReferenceOutputAssembly is true or empty.
/// All other values will be false.
/// </summary>
private static bool IsReferenceOutputAssemblyTrueOrEmpty(IVsReferenceItem item)
{
var value = GetPropertyValueOrNull(item, "ReferenceOutputAssembly");

return MSBuildStringUtility.IsTrueOrEmpty(value);
}
}
}