Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG] sale_cutoff_time_delivery: Migration to 14.0 #1403

Closed
wants to merge 11 commits into from
Closed

[MIG] sale_cutoff_time_delivery: Migration to 14.0 #1403

wants to merge 11 commits into from

Conversation

phuctranfxvn
Copy link
Contributor

No description provided.

@phuctranfxvn phuctranfxvn mentioned this pull request Dec 29, 2020
Open
87 tasks
sebalix
sebalix reviewed Aug 13, 2021
View reviewed changes
oca_dependencies.txt Outdated
@@ -1,2 +1,3 @@
# See https:/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#oca_dependencies-txt
stock-logistics-workflow
partner_tz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To remove

test-requirements.txt Outdated
@@ -0,0 +1 @@
odoo14-addon-partner-tz @ git+https:/trobz/[email protected]_tz#subdirectory=setup/partner_tz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has been merged, we can remove it now

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sebalix , sorry for late reply, I pushed the update

@mmequignon
Copy link
Member

@sebalix @TDu @jgrandguillaume @simahawk @jbaudoux
As discussed this is one of the modules that may be merged for v14.0.
Here's the thing :
We have 3 modules (sale_cutoff_time_delivery, sale_partner_time_window, sale_warehouse_calendar) that modifies the expected / scheduled dates, and are incompatible with each other because we have to somehow manage the order in which each one overrides sale.order.line_expected_date and sale.order.line._prepare_procurement_values.
The idea we discussed about is to merge those 3 modules in a single one which should deal with those delivery dates.

@dzungtran89 dzungtran89 force-pushed the 14.0-mig-sale_cutoff_time_delivery branch from 323f8e9 to 6d2fc7c Compare September 29, 2021 04:01
@dzungtran89 dzungtran89 force-pushed the 14.0-mig-sale_cutoff_time_delivery branch from 6d2fc7c to 066c89f Compare September 29, 2021 04:04
@dzungtran89
Copy link

we're checking why the travis failed

@hiepnh97 hiepnh97 mentioned this pull request Sep 29, 2021
Merged
@rousseldenis rousseldenis added this to the 14.0 milestone Sep 29, 2021
@mmequignon mmequignon mentioned this pull request Oct 7, 2021
Merged
@mmequignon
Copy link
Member

superseded by #1736

@simahawk simahawk closed this Oct 8, 2021
@hailangvn hailangvn deleted the 14.0-mig-sale_cutoff_time_delivery branch October 15, 2021 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebalix sebalix sebalix left review comments

@dzungtran89 dzungtran89 dzungtran89 left review comments

Assignees
No one assigned
Labels
migration needs review
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.