Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][MIG] sale_stock_available_to_promise_release_cutoff: Migration to 14.0 #304

Merged
merged 5 commits into from
Dec 3, 2021
Merged

[14.0][MIG] sale_stock_available_to_promise_release_cutoff: Migration to 14.0 #304

merged 5 commits into from
Dec 3, 2021

Conversation

hiepnh97
Copy link

@hiepnh97 hiepnh97 commented Sep 29, 2021 •
edited by sebalix
Loading

Notes:
This PR Depend on:

I will delete test-requirement.txt when depending on PR 1403 was Merge.

Ref. 3009

@rousseldenis rousseldenis added this to the 14.0 milestone Sep 29, 2021
@mmequignon
Copy link
Member

This PR should depend on OCA/sale-workflow#1736 instead.
Thanks !

@hailangvn
Copy link
Contributor

Thanks @mmequignon for your comment. We will work on this.

@dzungtran89 dzungtran89 force-pushed the 14.0-mig-sale_stock_available_to_promise_release_cutoff branch 2 times, most recently from 4f276e6 to 4fbb18d Compare October 14, 2021 07:36
@dzungtran89
Copy link
Contributor

Hi @mmequignon , the PR has been updated. btw the travis failed because the dependency is missing in setup dir`

@hailangvn hailangvn mentioned this pull request Oct 14, 2021
Closed
14 tasks
@sebalix
Copy link
Contributor

sebalix commented Nov 5, 2021

Thank you @hiepnh97 and @dzungtran89

@TDu
Copy link
Member

TDu commented Nov 12, 2021

I restarted Travis, because I just added the missing setup directory there https:/OCA/sale-workflow/pull/1736/commits

@dzungtran89
Copy link
Contributor

@TDu thx for your update

TDu
TDu approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@TDu TDu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG, should be squashed when sale_delivery_date has been merged

@sebalix
Copy link
Contributor

sebalix commented Dec 3, 2021

@dzungtran89 Hello! Commit Update sale_stock_available_to_promise_release_cutoff/readme/DESCRIPTION.rst can be squashed in the MIG commit I guess, and the TMP commit can be removed as sale_delivery_date has been merged

@hailangvn hailangvn force-pushed the 14.0-mig-sale_stock_available_to_promise_release_cutoff branch from ee533f0 to be0ef47 Compare December 3, 2021 11:46
@hailangvn
Copy link
Contributor

Thanks @sebalix for the comment, this PR has been updated.

@sebalix
Copy link
Contributor

sebalix commented Dec 3, 2021

@hailangvn thank you!
/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-304-by-sebalix-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit af5d8f7 into OCA:14.0 Dec 3, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3f804ce. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TDu TDu TDu approved these changes

@mmequignon mmequignon mmequignon approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.
9 participants
@hiepnh97 @mmequignon @hailangvn @dzungtran89 @sebalix @TDu @OCA-git-bot @rousseldenis @oca-travis