[14.0][MIG] sale_order_product_recommendation: Migration to 14.0 #1540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wizard that you can see now in your quotations will let you add products quickly based on the customer's recent purchase history.
We can't limit results on read_group, because we can't set the same criteria to order results, and thus the N groups populated might be not the top ones looked for.
- When a SO is confirmed the button is still visible so the wizard can be used to add or remove lines and products. The same restrictions that exist editing the order manually apply to the wizard.
Using force_save option in views
Updated by Update PO files to match POT (msgmerge) hook in Weblate.
- Improve test declaration inherability
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-12.0/sale-workflow-12.0-sale_order_product_recommendation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-12-0/sale-workflow-12-0-sale_order_product_recommendation/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-13.0/sale-workflow-13.0-sale_order_product_recommendation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_order_product_recommendation/
…ok products in recommendation wizard BTW I fixed a bug that counted products in the active SO as delivered, when it was impossible in most cases. Fixed the test to reflect the new logic. Co-Authored-By: Jairo Llopis <[email protected]>
Add kanban + form for proper mobile usage.
…fied` It's better to simply check the flag condition than to keep that field.
…t to product default one Having a related field to default sale secondary UoM makes this recommendator to not fit possible different secondary UoM to be used. This commit fixes this behavior. A refactoring on the main module having a prepare method hook has been needed.
…hanges Previous code was not very resilient to possible extra adaptations or require specific code to be added to the old hook `_trigger_so_line_onchanges`. With this, we make sure all onchanges are executed thanks to the odoo.tests.Form class. We lose a bit of performance, but it's better than to have issues with data not correctly synchronized.
…e wizard is launched
…ct.product model instead of product.template in wizard kanban view. TT26749
…recommendation wizard always sort by times delivered desc (even if the sale order already has any line)
…from pricelist or from last sale order
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: sale-workflow-13.0/sale-workflow-13.0-sale_order_product_recommendation Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_order_product_recommendation/
ShivamS-SerpentCS
changed the title
ShivamS-SerpentCS
changed the title
rousseldenis
reviewed
May 5, 2021
| "category": "Sales", | ||
| "website": "https:/OCA/sale-workflow", | ||
| "author": "Tecnativa, Odoo Community Association (OCA)", | ||
| "license": "AGPL-3", | ||
| "application": False, | ||
| "installable": True, | ||
| "depends": ["sale"], | ||
| "depends": ["sale_management"], |
There was a problem hiding this comment.
Why this change ?
rousseldenis
reviewed
May 5, 2021
| @@ -107,7 +107,7 @@ def _generate_recommendations(self): | |||
| key=lambda res: (res["product_id_count"], res["qty_delivered"]), | |||
| reverse=True, | |||
| ) | |||
| found_dict = {l["product_id"][0]: l for l in found_lines} | |||
| found_dict = {L["product_id"][0]: L for L in found_lines} | |||
There was a problem hiding this comment.
If warning was to change, not to go for caps. 😄 'line' is better
|
@ShivamS-SerpentCS any plans to finish/merge this one? |
|
Please include #1980 |
|
Please include #2065 |
|
@ShivamS-SerpentCS Do you plan to continue this ? |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.