Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][IMP] sale_order_product_recommendation: Exclude delivery carrier products from recommendations #1980

Merged
merged 1 commit into from
Jun 3, 2022
Merged

[13.0][IMP] sale_order_product_recommendation: Exclude delivery carrier products from recommendations #1980

merged 1 commit into from
Jun 3, 2022

Conversation

sergio-teruel
Copy link
Contributor

@sergio-teruel sergio-teruel force-pushed the 13.0-sale_order_product_recommendation-exclude-product-carriers branch from 2021628 to cf6447a Compare April 12, 2022 20:19
@pedrobaeza pedrobaeza added this to the 13.0 milestone Apr 12, 2022
pedrobaeza
pedrobaeza reviewed Apr 12, 2022
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not directly exclude SO lines with is_delivery field set to True?

@sergio-teruel sergio-teruel force-pushed the 13.0-sale_order_product_recommendation-exclude-product-carriers branch from cf6447a to e27301d Compare April 13, 2022 10:33
@sergio-teruel
Copy link
Contributor Author

@pedrobaeza Changes done!!

@rousseldenis
Copy link
Sponsor Contributor

Mmmh, don't like code based on unloaded things. The best is to do a glue module...

@pedrobaeza
Copy link
Member

Well, it's a good trade-off. We know that it's not the perfect one, but have a glue module *_delivery for every module we have... Did you contribute in Odoo a hook method for excluding SO lines that is hooked by delivery module? I remember something like that. That can be a good alternative.

@sergio-teruel sergio-teruel force-pushed the 13.0-sale_order_product_recommendation-exclude-product-carriers branch from e27301d to eb3ab18 Compare June 2, 2022 07:29
@sergio-teruel
Copy link
Contributor Author

Hi
We can not use the method _is_delivery() from sale module because we are doing a domain for a readgroup query.

@sergio-teruel sergio-teruel force-pushed the 13.0-sale_order_product_recommendation-exclude-product-carriers branch from eb3ab18 to 0289b0c Compare June 3, 2022 11:12
@sergio-teruel
Copy link
Contributor Author

Changes done!

@pedrobaeza
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-1980-by-pedrobaeza-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 656d4b3 into OCA:13.0 Jun 3, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 837386a. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza mentioned this pull request Jun 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@carlosdauden carlosdauden carlosdauden approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.
5 participants
@sergio-teruel @rousseldenis @pedrobaeza @OCA-git-bot @carlosdauden