Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] sale_partner_incoterm #1955

Merged
merged 36 commits into from
Mar 2, 2023
Merged

[15.0][MIG] sale_partner_incoterm #1955

merged 36 commits into from
Mar 2, 2023

Conversation

vvrossem
Copy link
Contributor

No description provided.

@vvrossem vvrossem mentioned this pull request Mar 22, 2022
Open
@oca-clabot
Copy link

Hey @vvrossem, thank you for your Pull Request.

It looks like some users haven't signed our Contributor License Agreement, yet.
You can read and sign our full Contributor License Agreement here: http://odoo-community.org/page/cla
Here is a list of the users:

Appreciation of efforts,
OCA CLAbot

@vvrossem vvrossem mentioned this pull request Apr 8, 2022
Closed
@vvrossem
Copy link
Contributor Author

vvrossem commented Apr 8, 2022

Hi @ReedHayashikawa, @jimhoefnagels, @StefanRijnhart , @lbelorgey, could you please review this PR ? 🙏 thank you

@rousseldenis rousseldenis added this to the 15.0 milestone Apr 8, 2022
@rousseldenis
Copy link
Sponsor Contributor

/ocabot migration sale_partner_incoterm

rousseldenis
rousseldenis approved these changes Apr 8, 2022
View reviewed changes
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review. You can add yourself in readme/CONTRIBUTORS.rst

@vvrossem
Copy link
Contributor Author

Thank you for the review @rousseldenis !

dhx
dhx approved these changes Aug 2, 2022
View reviewed changes
Copy link

@dhx dhx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

1 similar comment
@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dreispt
Copy link
Sponsor Member

dreispt commented Aug 10, 2022

/ocbot merge nobump

@StefanRijnhart
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 15.0-ocabot-merge-pr-1955-by-StefanRijnhart-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 4, 2022
@OCA-git-bot
Merge PR #1955 into 15.0
b933ee1 
Signed-off-by StefanRijnhart
@OCA-git-bot
Copy link
Contributor

@StefanRijnhart your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-1955-by-StefanRijnhart-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@OCA-git-bot
Copy link
Contributor

@StefanRijnhart your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-1955-by-StefanRijnhart-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@StefanRijnhart
Copy link
Member

@vvrossem pre-commit requirements seem to have changed slightly. Can you trigger pre-commit again on this code and commit the setup directory?

Run newfiles="$(git ls-files --others --exclude-from=.gitignore)"
Please check-in the following files:
setup/sale_partner_incoterm/odoo/addons/sale_partner_incoterm
setup/sale_partner_incoterm/setup.py
Error: Process completed with exit code 1.

@yankinmax
Copy link
Contributor

@vvrossem can you pls rebase on updated 15.0 branch, pre-commit issues should be solved now

oca-travis and others added 17 commits March 2, 2023 15:43
@oca-travis @vvrossem
[UPD] Update sale_partner_incoterm.pot
c482ce6
@OCA-git-bot @vvrossem
[UPD] README.rst
d4ce106
@oca-transbot @vvrossem
Update translation files
c235a5c 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-13.0/sale-workflow-13.0-sale_partner_incoterm
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_partner_incoterm/
@danimv5 @vvrossem
Translated using Weblate (Spanish)
1eba622 
Currently translated at 100.0% (4 of 4 strings)

Translation: sale-workflow-13.0/sale-workflow-13.0-sale_partner_incoterm
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_partner_incoterm/es/
@jimhoefnagels @vvrossem
[MIG] sale_partner_incoterm: Migration to 13.0
6713969
@oca-transbot @vvrossem
Update translation files
9bc6846 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: sale-workflow-13.0/sale-workflow-13.0-sale_partner_incoterm
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-13-0/sale-workflow-13-0-sale_partner_incoterm/
@OCA-git-bot @vvrossem
sale_partner_incoterm 13.0.1.0.1
a70bbbb
@vvrossem
[IMP] sale_partner_incoterm: black, isort, prettier
56dba4e
@vvrossem
[MIG] sale_partner_incoterm: Migration to 14.0
becf265
@vvrossem
[FIX] Removed unnecessary code
41638de
@oca-travis @vvrossem
[UPD] Update sale_partner_incoterm.pot
4d11b8d
@OCA-git-bot @vvrossem
[UPD] README.rst
2c6c016
@danimv5 @vvrossem
Added translation using Weblate (Catalan)
bcc4526
@danimv5 @vvrossem
Translated using Weblate (Catalan)
aa66c28 
Currently translated at 100.0% (7 of 7 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_partner_incoterm
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_partner_incoterm/ca/
@bosd @vvrossem
Translated using Weblate (Dutch)
aa90d82 
Currently translated at 75.0% (3 of 4 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_partner_incoterm
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_partner_incoterm/nl/
@Yvesldff @vvrossem
Translated using Weblate (French)
2ac0f78 
Currently translated at 75.0% (3 of 4 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_partner_incoterm
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_partner_incoterm/fr/
@marylla @vvrossem
Translated using Weblate (German)
09fd05f 
Currently translated at 100.0% (4 of 4 strings)

Translation: sale-workflow-14.0/sale-workflow-14.0-sale_partner_incoterm
Translate-URL: https://translation.odoo-community.org/projects/sale-workflow-14-0/sale-workflow-14-0-sale_partner_incoterm/de/
@vvrossem vvrossem force-pushed the 15.0-mig-sale_partner_incoterm branch 2 times, most recently from 1031c76 to 47c494a Compare March 2, 2023 14:49
@vvrossem vvrossem force-pushed the 15.0-mig-sale_partner_incoterm branch from 47c494a to 2110b34 Compare March 2, 2023 14:50
@vvrossem
Copy link
Contributor Author

vvrossem commented Mar 2, 2023

@StefanRijnhart @dreispt @yankinmax Apologies for the late reply 🙏
All tests are now green ✅

@dreispt
Copy link
Sponsor Member

dreispt commented Mar 2, 2023

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-1955-by-dreispt-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9fa8e64 into OCA:15.0 Mar 2, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9f77297. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhx dhx dhx approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs fixing ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.