fix: fix pika coredump when process exit #1820
Conversation
PikaReplServer cleanup connections when destroy function called, cleanup will trigger FdClosedHandle which calls already destroyed pikaserver. So manually call cleanup ahead before pikaserver destroyed.
![cr-gpt[bot]](https://avatars.githubusercontent.com/in/292659?s=60&v=4){kind=small}
| @@ -72,7 +73,6 @@ class HolyThread : public ServerThread { | |||
| void HandleConnEvent(NetFiredEvent* pfe) override; | |||
|
|
|||
| void CloseFd(const std::shared_ptr<NetConn>& conn); | |||
| void Cleanup(); | |||
| }; // class HolyThread | |||
|
|
|||
| } // namespace net | |||
There was a problem hiding this comment.
Based on the provided code patch, here's a brief code review:
-
In the
HolyThreadclass, you have added a new method calledCleanup(). Make sure to implement this method correctly. -
You have marked
Cleanup()as bothoverrideandprivate. If this method is meant to override a base class method, ensure that the signature and return type match exactly. -
In the
HolyThreadclass, the methodHandleConnEvent(NetFiredEvent* pfe)seems to be missing from the code patch. Check if it has been mistakenly omitted or moved elsewhere. -
The method
CloseFd(const std::shared_ptr<NetConn>& conn)should be implemented according to its purpose to ensure proper cleanup and closure of file descriptors.
Overall, without having the complete codebase, it's difficult to identify additional bug risks or suggest specific improvements. It is important to thoroughly test the modified code and handle error conditions appropriately. Additionally, ensure that the changes align with the intended functionality and adhere to the best coding practices of the existing codebase.
PikaReplServer cleanup connections when destroy function called, cleanup will trigger FdClosedHandle which calls already destroyed pikaserver. So manually call cleanup ahead before pikaserver destroyed. Co-authored-by: wangshaoyi <[email protected]>
PikaReplServer cleanup connections when destroy function called, cleanup will trigger FdClosedHandle which calls already destroyed pikaserver. So manually call cleanup ahead before pikaserver destroyed. Co-authored-by: wangshaoyi <[email protected]>
修复pika进程退出时的coredump。 #1819
出现问题的原因是pika_repl_server在执行FdClosedHandle时会用到pika_server，pika_server已经析构了，所以coredump.
修复方式是pika_repl_server在stop时，关闭掉连接。