fix: fix pika coredump when process exit (OpenAtomFoundation#1820)

PikaReplServer cleanup connections when destroy function called, cleanup will trigger FdClosedHandle which calls already destroyed pikaserver. So manually call cleanup ahead before pikaserver destroyed. Co-authored-by: wangshaoyi <[email protected]>
bigdaronlee163 · Jul 26, 2023 · 48c9703 · 48c9703
1 parent 1c54ea5
commit 48c9703
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/src/net/src/holy_thread.h b/src/net/src/holy_thread.h
@@ -52,6 +52,7 @@ class HolyThread : public ServerThread {
  virtual std::shared_ptr<NetConn> get_conn(int fd);
 
  void ProcessNotifyEvents(const net::NetFiredEvent* pfe) override;
+ void Cleanup();
 
  private:
  mutable pstd::RWMutex rwlock_; /* For external statistics */
@@ -72,7 +73,6 @@ class HolyThread : public ServerThread {
  void HandleConnEvent(NetFiredEvent* pfe) override;
 
  void CloseFd(const std::shared_ptr<NetConn>& conn);
- void Cleanup();
 }; // class HolyThread
 
 } // namespace net

diff --git a/src/pika_repl_server.cc b/src/pika_repl_server.cc
@@ -46,6 +46,7 @@ int PikaReplServer::Start() {
 int PikaReplServer::Stop() {
  server_tp_->stop_thread_pool();
  pika_repl_server_thread_->StopThread();
+ pika_repl_server_thread_->Cleanup();
  return 0;
 }