fix migrate big key problem and add auth for semi-async #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancy-rabbit
approved these changes
Jan 16, 2018
There was a problem hiding this comment.
emmmm. I submitted #236 to revert your synchronized Recv(), revert the 1k MaxKeySendSize back to 10k.
| @@ -8,7 +8,7 @@ | |||
| #include "strings.h" | |||
|
|
|||
| const std::string SlotKeyPrefix = "_internal:slotkey:4migrate:"; | |||
| const size_t MaxKeySendSize = 10 * 1024; | |||
| const size_t MaxKeySendSize = 1024; | |||
There was a problem hiding this comment.
won't be necessary after Qihoo360/pink@51e4bbe#diff-9b6af85329e3015c44cf81fb59fd1686
take effects in pika?
| return -1; | ||
| } | ||
| // Recv | ||
| s = cli->Recv(NULL); |
There was a problem hiding this comment.
this may bring down performance.
but considering about the condition that large keys are sliced into multiple pieces(batches for migration), it might be the clearest and simplest solution to avoid the possibility of leaving garbage data in socket buffers.
There was a problem hiding this comment.
found a way works well when large keys are sliced. see #236
Merged
chejinge
pushed a commit
to chejinge/pika
that referenced
this pull request
Oct 27, 2023
….1.3 Improvement: using pikiwidb/rediscache v0.1.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.