Fix async migrate #236
Merged
Fix async migrate #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @Leviathan1995 @KernelMaker how is it going? |
|
Thanks! |
bigdaronlee163
pushed a commit
to bigdaronlee163/pika
that referenced
this pull request
Jun 8, 2024
* fix migrate big key and add auth for semi-async * pipeline recv() for improving migration performance
cheniujh
pushed a commit
to cheniujh/pika
that referenced
this pull request
Sep 24, 2024
* fix migrate big key and add auth for semi-async * pipeline recv() for improving migration performance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR is based on #235 and improve it by pipelining recv() to improve migration performance.
I changed the return value of functions for migrating non-KV keys to represent the number of cli->Send() calling, and thereafter identical number of Recv() are called.
@left2right @KernelMaker
Known issue: (may be fixed when I have time in the next weeks/months...)
0. KeyDelete() does NOT write binlog, the deletions aren't propagated to the slaves correctly.