Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "int-he" and replace "int-en" with "lang-font" class #271

Open
2 tasks
lobsam opened this issue Aug 19, 2024 · 0 comments
Open
2 tasks

Remove "int-he" and replace "int-en" with "lang-font" class #271

lobsam opened this issue Aug 19, 2024 · 0 comments

Comments

@lobsam
Copy link
Collaborator

lobsam commented Aug 19, 2024

Description :

Sefaria has put in place in template file or in react, only two language system (ie; english and hebrew). And adding new languages makes it complicated.

for an example :

                            <span class="int-en">{% trans "Add Source Title" %}</span>
                            <span class="int-he">{% trans "Add Source Title" %}</span>

if pecha.org is switch to english, styled int-he makes hebrew(tibetan) language invisible. But when add new language
(eg;chinese) then both strings get shown. and to solve it adding int-zh class would be impossible for adding future languages.

So the only option is to delete the int-he contained line and replace int-en class with lang-font class name. And replace in css int-en class to lang-font so that applied font-family wouldn't get effected.

This would make possible for adding more languages without any issue and remove the two language system from pecha.org.

Implementation steps:

  • Remove existing "int-he" class for all the strings and replace all the "int-en" with "lang-font" class both in django template.

  • Apply lang-font class in css for font-family and other avail styling.

@Lungsangg Lungsangg changed the title modify code in backend that support schema changes in collection for chinese Remove existing "int-he" class for all the strings and replace all the "int-en" with "lang-font" class both in react and django template Aug 21, 2024
@Lungsangg Lungsangg changed the title Remove existing "int-he" class for all the strings and replace all the "int-en" with "lang-font" class both in react and django template Remove "int-he" and replace "int-en" with "lang-font" class Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant