Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC002: Chinese localization implementation in code #90

Closed
7 tasks done
Lungsangg opened this issue Aug 16, 2024 · 1 comment
Closed
7 tasks done

RFC002: Chinese localization implementation in code #90

Lungsangg opened this issue Aug 16, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@Lungsangg
Copy link
Contributor

Lungsangg commented Aug 16, 2024

This RFC002 solves RFW01

Description :

Pecha.org (which is an instance of sefaria.org) has two language ie, English and Tibetan. And need to add Chinese language feature (with more languages in future). With current localization setup, for backend, django po file is used and in frontend a js file (which have strings in english Tibetan key value pair).

A chinese language feature need to implement in code for this task.

Dependencies :

  • modified string.js file that contains English, Tibetan and Chinese strings used in frontend.
  • A django po file for chinese translations.

Justification :

There are two method to implement multiple language support for pecha.org. First one is to customize currenly implemented method by sefaria and second one is to discard all the sefaria method and implement reacti8n library on frontend.
We chose the first method as it is implementable in the current given time and implementing reacti8n library would needs lots of changes in code that sefaria have put in place.

Implementation steps :

React

Django

@Lungsangg
Copy link
Contributor Author

@kaldan007 @drupchen, Sandup and me are going though code today and will meet tomorrow morning to write rfc.

@lobsam lobsam added the enhancement New feature or request label Aug 19, 2024
@ta4tsering ta4tsering assigned drupchen and unassigned lobsam and Lungsangg Aug 22, 2024
@Lungsangg Lungsangg assigned Lungsangg and drupchen and unassigned drupchen and Lungsangg Aug 22, 2024
@Lungsangg Lungsangg transferred this issue from OpenPecha/Pecha.org Aug 23, 2024
@Lungsangg Lungsangg added this to the v1.2.0 (23-08-2024) milestone Aug 23, 2024
@Lungsangg Lungsangg closed this as completed by moving to DONE in Pecha.org Web Dev Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: DONE
Development

No branches or pull requests

3 participants