Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yahoo! OpenID (2.0) EOL notice #1733

Open
Martii opened this issue Aug 16, 2020 · 1 comment
Open

Yahoo! OpenID (2.0) EOL notice #1733

Martii opened this issue Aug 16, 2020 · 1 comment
Assignees
@sizzlemctwizzle
Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. hung Not what you are thinking. Unable to resolve after assignment. migration Use this to indicate that it may apply to an existing or announced migration. security Usually relates to something critical.

Comments

@Martii
Copy link
Member

Martii commented Aug 16, 2020 •
edited
Loading

Migration path doc at https://developer.yahoo.com/oauth2/guide/OpenID2/ . Migrating from OpenID2 to OpenID Connect which appears to be OAuth 2 mentioned at https://developer.yahoo.com/oauth2/guide/openid_connect/getting_started.html

Since Yahoo doesn't bother dating their announcements I have no idea when this happened and for how long. :\

Anyhow... I'm guessing if the Yahoo authentication wants to be salvaged this will need to be done... if it's not too late. The passport strategies, all of them, really ought to have a way of notifying everyone via their connections in node... just my opinion.

I disabled new account attempts at #1732

Misc notes:

  • I'm guessing since passport-steam has been handling their own that should continue but one never knows for sure.
  • Error in logs are as follows:
2020-08-16 07:59:47.499 +00:00: InternalOpenIDError: Failed to discover OP endpoint URL
    at ~/OpenUserJS.org2/node_modules/passport-openid-node6support/lib/passport-openid/strategy.js:249:52

... which from past experience with Google/AOL means their default URL is invalid now... so migration may not be possible. IDK ATM. The sub-dep was forked to update OpenID and I figured these were going the way of the Dodo.

  • Since @sizzlemctwizzle is in charge of the Auth Strategy API keys... he'll definitely have to be involved.

Outside refs:
@Martii Martii added security Usually relates to something critical. migration Use this to indicate that it may apply to an existing or announced migration. CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. labels Aug 16, 2020
Martii added a commit to Martii/OpenUserJS.org that referenced this issue Aug 17, 2020
@Martii
Pseudo cross-browser styling for readonly Auth Strategies
9dc091a 
* Using this as a subtle notice that a strategy has been disabled in case someone isn't watching dev
* Fx still doesn't support styling unfortunately *( https://bugzilla.mozilla.org/show_bug.cgi?id=910022 )* so plain disable it. Should cut down on b/w but also possible Code testing increase with visible delineation in dev.

Post OpenUserJS#1174 and reminder-ed in OpenUserJS#1189 ... related to OpenUserJS#1732 OpenUserJS#1733
@Martii Martii mentioned this issue Aug 17, 2020
Merged
Martii added a commit that referenced this issue Aug 17, 2020
@Martii
Pseudo cross-browser styling for readonly Auth Strategies (#1734)
ff1e6cf 
* Using this as a subtle notice that a strategy has been disabled in case someone isn't watching dev
* Fx still doesn't support styling unfortunately *( https://bugzilla.mozilla.org/show_bug.cgi?id=910022 )* so plain disable it. Should cut down on b/w but also possible Code testing increase with visible delineation in dev.

Post #1174 and reminder-ed in #1189 ... related to #1732 #1733

Auto-merge
@Martii
Copy link
Member Author

Martii commented Aug 17, 2020

Btw I don't even see an OAuth 2.0 passport at http://www.passportjs.org/ , just http://www.passportjs.org/packages/passport-yahoo-oauth/ which is 1.0a (API). There might be some forks around that might support it will have to do some digging when the chance permits.

Martii added a commit to Martii/OpenUserJS.org that referenced this issue Aug 23, 2020
@Martii
Remove Yahoo passport completely
412ffdc 
* With the original process manager running our app this is the last message in it. It also says the process is still running but this is a first for me seeing the process still running but complete hanging. We'll see how this goes next round.

Applies to OpenUserJS#1733 and possibly OpenUserJS#1733
@Martii Martii mentioned this issue Aug 23, 2020
Merged
Martii added a commit that referenced this issue Aug 23, 2020
@Martii
Remove Yahoo passport completely (#1741)
4727580 
* With the original process manager running our app this is the last message in it. It also says the process is still running but this is a first for me seeing the process still running but complete hanging. We'll see how this goes next round.

Applies to #1733 and possibly #1727 
Auto-merge
@Martii Martii added the hung Not what you are thinking. Unable to resolve after assignment. label Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sizzlemctwizzle sizzlemctwizzle

Labels
CODE Some other Code related issue and it should clearly describe what it is affecting in a comment. hung Not what you are thinking. Unable to resolve after assignment. migration Use this to indicate that it may apply to an existing or announced migration. security Usually relates to something critical.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sizzlemctwizzle @Martii