-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split Login and Register into two parts #1174
Conversation
* Something @sizzlemctwizzle suggested he might want from an idea he had with a little twist from myself. I think this covers what you are describing plus a little extra. NOTES: * There can be more to do with this if needed. * This shows the sanitized name as indicated in a previous discussion about it. Added a note about it in the CAUTION alert. * If an existing user needs to change their auth method, **and they are not already logged in with their preferred**, just page back from whatever auth page there is *(say GH's login prompt)* and it will give the register screen... otherwise use the Preferences to initially add an alternate authentication to an existing account.
@sizzlemctwizzle |
If you still want an ajax listener it is preferred to be handled before calling out the form/route request using the not-existing-yet This minimal amount of JavaScript won't hurt those that don't like enabling JavaScript by default... but could be abused still... they'll just need to figure it out the current existing method... that's already in place. If you still don't want to split the screens into two, as is, then let me know an I'll remove the mustache conditionals... but the biggest confusion I've encountered from others is having two input boxes with the same username (sanitized or not) on the same screen. Usually they type in their email address next to the auth drop list/register button after they've already chosen a username in the upper input... that's where it gets blech. Slowing registration options down should ease this. Flipping auths is still possible when there's a development issue but just a little more obfuscated than it already is. The needs of the many outweigh the needs of the few... in this case. ;) :) |
Post change to OpenUserJS#1174
Post change to #1174 Auto-merge
* This has always buggered me... Sign In / Sign Up / Sign Out **or** Login / Register / Logout is preferred... choosing the former for human readable. Post OpenUserJS#1174
* This has always buggered me... Sign In / Sign Up / Sign Out **or** Login / Register / Logout is preferred... choosing the former for human readable. Post #1174 Auto-merge
Post change on OpenUserJS#1174
Post change on #1174 Auto-merge
More of option 2 * Hides this a little more during disabled state but still show dropdown for confirmation of what types we currently support and when. * Give a local alert page reload in case the nav bar is collapsed and the browser is hiding/absent with the page reload. `history.go(0)` only reloads the page itself and doesn't trigger requests to other resources * Some more alert tweaking Post OpenUserJS#1174
* Don't select default auth. * Hide some more of the items that are disabled * Put a local page reload in the alert in case the nav bar is collapsed. `history.go(0)` only attempts reloads the page and no other resources. Applies to OpenUserJS#1174
* Don't select default auth. * Hide some more of the items that are disabled * Put a local page reload in the alert in case the nav bar is collapsed. `history.go(0)` only attempts reloads the page and no other resources. Applies to #1174 Auto-merge
* Change some labels again * Client side JS, but not required * Use a HEAD request route to see if exists * Use some `noscript` tags in view... alter refresh for scriptable * Going to try a real-time check... will watch server load for a bit NOTE(S): * Combining these is not recommended because the input text area can be super small on portable devices and if JavaScript is disabled it would prevent any chance of toggling auths * *express* does seem to have a default HEAD but it is unpredictable in implementation Post OpenUserJS#1174
* Change some labels again * Client side JS, but not required * Use a HEAD request route to see if exists * Use some `noscript` tags in view... alter refresh for scriptable * Going to try a real-time check... will watch server load for a bit NOTE(S): * Combining these is not recommended because the input text area can be super small on portable devices and if JavaScript is disabled it would prevent any chance of toggling auths * *express* does seem to have a default HEAD but it is unpredictable in implementation Post #1174 Auto-merge
* Similar to `countTask` but **without** the host CPU/MEM bulk of *async* and related abstraction. * Returns the cursor count, instead of the document, which can be smaller usually Post OpenUserJS#1174
Been working on this too long looking for options ;) Post #1174 Auto-merge
* Safari is being picky plus usernames don't have to be grammatcially correct * Turn off some others... not all are outside of Safari Post OpenUserJS#1174
* Safari is being picky plus usernames don't have to be grammatcially correct * Turn off some others... not all are outside of Safari Post #1174 Auto-merge
* Less wordy * Typo Post OpenUserJS#1174
* Less wordy * Typo Post #1174 Auto-merge
* Normalize on `/login`... keep `register` to ourselves in the code... we already do this a lot... think `index.js` vs `main`. * Removed one dead route... why would we want to do `/github` to `/`... means to me that it's dead... just return a default 404. * Fixed one doc send with status 302 to redirect instead... default is 302 ... would use a 307 but that's only HTTP/1.1 and would definitely rule out any older browser although may be reconsidered at a later date * Some white space treatment Applies to OpenUserJS#1198 OpenUserJS#135 and post OpenUserJS#1174
* Deprecate some routes * Normalize on `/login`... keep `register` to ourselves in the code... we already do this a lot... think `index.js` vs `main`. * Removed one dead route... why would we want to do `/github` to `/`... means to me that it's dead... just return a default 404. * Fixed one doc send with status 302 to redirect instead... default is 302 ... would use a 307 but that's only HTTP/1.1 and would definitely rule out any older browser although may be reconsidered at a later date * Some white space treatment Applies to #1198 #135 and post #1174 * Undeprecate a route * Added a note Applies to #135 * Remove this route since it won't exist Applies to #135 * Revert last commit * Will exist for hook but root of it won't Applies to #135
* Using vanilla JavaScript client-side again. More accurate for single inputs. * Disable MSIE's native... will test shortly Loosely related to post OpenUserJS#1174 and followup for OpenUserJS#1210
* Remember and recall consents * Speeds up logging in if we already have it NOTES: * Good thing I twiddled with this before :) Post OpenUserJS#1174 and OpenUserJS#1385 'ish
* Using this as a subtle notice that a strategy has been disabled in case someone isn't watching dev * Fx still doesn't support styling unfortunately *( https://bugzilla.mozilla.org/show_bug.cgi?id=910022 )* so plain disable it. Should cut down on b/w but also possible Code testing increase with visible delineation in dev. Post OpenUserJS#1174 and reminder-ed in OpenUserJS#1189 ... related to OpenUserJS#1732 OpenUserJS#1733
* Using this as a subtle notice that a strategy has been disabled in case someone isn't watching dev * Fx still doesn't support styling unfortunately *( https://bugzilla.mozilla.org/show_bug.cgi?id=910022 )* so plain disable it. Should cut down on b/w but also possible Code testing increase with visible delineation in dev. Post #1174 and reminder-ed in #1189 ... related to #1732 #1733 Auto-merge
* May assist a little on some portables and desktops * macOS *(Catalina)* doesn't seem to support some attributes in any tested browser * SM doesn't seem to support some attributes Post OpenUserJS#1194 OpenUserJS#1174
* Custom classes similar to *bootstrap*s * Apparently a few still don't know how to read, this should help alleviate any excuses/confusion. Post OpenUserJS#1174
* Custom classes similar to *bootstrap*s * Apparently a few still don't know how to read, this should help alleviate any excuses/confusion. Post #1174 Auto-merge
NOTES:
Applies to: