Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split Login and Register into two parts #1174

Merged
merged 1 commit into from
Oct 16, 2017

Conversation

Martii
Copy link
Member

@Martii Martii commented Oct 16, 2017

  • Something @sizzlemctwizzle suggested he might want from an idea he had with a little twist from myself. I think this covers what you are describing plus a little extra.

NOTES:

  • There can be more to do with this if needed.
  • This shows the sanitized name as indicated in a previous discussion about it. Added a note about it in the CAUTION alert.
  • If an existing user needs to change their auth method, and they are not already logged in with their preferred, just page back from whatever auth page there is (say GH's login prompt) and it will give the register screen... otherwise use the Preferences to initially add an alternate authentication to an existing account.

Applies to:

* Something @sizzlemctwizzle suggested he might want from an idea he had with a little twist from myself. I think this covers what you are describing plus a little extra.

NOTES:
* There can be more to do with this if needed.
* This shows the sanitized name as indicated in a previous discussion about it. Added a note about it in the CAUTION alert.
* If an existing user needs to change their auth method, **and they are not already logged in with their preferred**, just page back from whatever auth page there is *(say GH's login prompt)* and it will give the register screen... otherwise use the Preferences to initially add an alternate authentication to an existing account.
@Martii Martii added enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface. labels Oct 16, 2017
@Martii Martii merged commit 43929bd into OpenUserJS:master Oct 16, 2017
@Martii Martii deleted the splitLoginRegister branch October 16, 2017 07:48
@Martii
Copy link
Member Author

Martii commented Oct 16, 2017

@sizzlemctwizzle
This should alleviate #233 from being handled by Admin+ totally (e.g. imho it can be closed and I shouldn't have to do that any more in a DB migration). A new user gets a chance to see/preview what username they are going to end up with and have an option to change it. This also isolates the registration attachment to a separate screen to eliminate that confusion. The wording fits within the guidelines that you mentioned to me earlier.

@Martii
Copy link
Member Author

Martii commented Oct 16, 2017

If you still want an ajax listener it is preferred to be handled before calling out the form/route request using the not-existing-yet User.search client-side API that you mentioned. I advise against a real time search like Groups and that many DB lookups could get messy (for this case something like User.findOne client side API and a cleanfilename routine is recommended on "Sign-In" which might be renamed to "Next" soon... if you feel the host can handle it then make it live but may have consequences).

This minimal amount of JavaScript won't hurt those that don't like enabling JavaScript by default... but could be abused still... they'll just need to figure it out the current existing method... that's already in place.


If you still don't want to split the screens into two, as is, then let me know an I'll remove the mustache conditionals... but the biggest confusion I've encountered from others is having two input boxes with the same username (sanitized or not) on the same screen. Usually they type in their email address next to the auth drop list/register button after they've already chosen a username in the upper input... that's where it gets blech. Slowing registration options down should ease this. Flipping auths is still possible when there's a development issue but just a little more obfuscated than it already is. The needs of the many outweigh the needs of the few... in this case. ;) :)

Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Oct 16, 2017
@Martii Martii mentioned this pull request Oct 16, 2017
Martii added a commit that referenced this pull request Oct 16, 2017
Post change to #1174 

Auto-merge
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Oct 16, 2017
Martii added a commit that referenced this pull request Oct 16, 2017
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Oct 16, 2017
@Martii Martii mentioned this pull request Oct 16, 2017
Martii added a commit that referenced this pull request Oct 16, 2017
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Oct 16, 2017
* This has always buggered me... Sign In / Sign Up / Sign Out **or** Login / Register / Logout is preferred... choosing the former for human readable.

Post OpenUserJS#1174
Martii added a commit that referenced this pull request Oct 16, 2017
* This has always buggered me... Sign In / Sign Up / Sign Out **or** Login / Register / Logout is preferred... choosing the former for human readable.

Post #1174 
Auto-merge
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Oct 17, 2017
@Martii Martii mentioned this pull request Oct 17, 2017
Martii added a commit that referenced this pull request Oct 17, 2017
Post change on #1174 

Auto-merge
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Oct 17, 2017
More of option 2

* Hides this a little more during disabled state but still show dropdown for confirmation of what types we currently support and when.
* Give a local alert page reload in case the nav bar is collapsed and the browser is hiding/absent with the page reload. `history.go(0)` only reloads the page itself and doesn't trigger requests to other resources
* Some more alert tweaking

Post OpenUserJS#1174
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Oct 17, 2017
* Don't select default auth.
* Hide some more of the items that are disabled
* Put a local page reload in the alert in case the nav bar is collapsed. `history.go(0)` only attempts reloads the page and no other resources.

Applies to OpenUserJS#1174
Martii added a commit that referenced this pull request Oct 17, 2017
* Don't select default auth.
* Hide some more of the items that are disabled
* Put a local page reload in the alert in case the nav bar is collapsed. `history.go(0)` only attempts reloads the page and no other resources.

Applies to #1174

Auto-merge
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Oct 17, 2017
* Change some labels again
* Client side JS, but not required
* Use a HEAD request route to see if exists
* Use some `noscript` tags in view... alter refresh for scriptable
* Going to try a real-time check... will watch server load for a bit

NOTE(S):
* Combining these is not recommended because the input text area can be super small on portable devices and if JavaScript is disabled it would prevent any chance of toggling auths
* *express* does seem to have a default HEAD but it is unpredictable in implementation

Post OpenUserJS#1174
@Martii Martii mentioned this pull request Oct 17, 2017
Martii added a commit that referenced this pull request Oct 17, 2017
* Change some labels again
* Client side JS, but not required
* Use a HEAD request route to see if exists
* Use some `noscript` tags in view... alter refresh for scriptable
* Going to try a real-time check... will watch server load for a bit

NOTE(S):
* Combining these is not recommended because the input text area can be super small on portable devices and if JavaScript is disabled it would prevent any chance of toggling auths
* *express* does seem to have a default HEAD but it is unpredictable in implementation

Post #1174

Auto-merge
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Oct 18, 2017
* Similar to `countTask` but **without** the host CPU/MEM bulk of *async* and related abstraction.
* Returns the cursor count, instead of the document, which can be smaller usually

Post OpenUserJS#1174
Martii added a commit that referenced this pull request Oct 21, 2017
Been working on this too long looking for options ;)

Post #1174 

Auto-merge
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Oct 22, 2017
@Martii Martii mentioned this pull request Oct 22, 2017
Martii added a commit that referenced this pull request Oct 22, 2017
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Oct 22, 2017
* Safari is being picky plus usernames don't have to be grammatcially correct
* Turn off some others... not all are outside of Safari

Post OpenUserJS#1174
Martii added a commit that referenced this pull request Oct 22, 2017
* Safari is being picky plus usernames don't have to be grammatcially correct
* Turn off some others... not all are outside of Safari

Post #1174

Auto-merge
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Oct 22, 2017
* Less wordy
* Typo

Post OpenUserJS#1174
@Martii Martii mentioned this pull request Oct 22, 2017
Martii added a commit that referenced this pull request Oct 22, 2017
* Less wordy
* Typo

Post #1174

Auto-merge
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Oct 24, 2017
* Normalize on `/login`... keep `register` to ourselves in the code... we already do this a lot... think `index.js` vs `main`.
* Removed one dead route... why would we want to do `/github` to `/`... means to me that it's dead... just return a default 404.
* Fixed one doc send with status 302 to redirect instead... default is 302 ... would use a 307 but that's only HTTP/1.1 and would definitely rule out any older browser although may be reconsidered at a later date
* Some white space treatment

Applies to OpenUserJS#1198 OpenUserJS#135 and post OpenUserJS#1174
@Martii Martii mentioned this pull request Oct 24, 2017
Martii added a commit that referenced this pull request Oct 24, 2017
* Deprecate some routes

* Normalize on `/login`... keep `register` to ourselves in the code... we already do this a lot... think `index.js` vs `main`.
* Removed one dead route... why would we want to do `/github` to `/`... means to me that it's dead... just return a default 404.
* Fixed one doc send with status 302 to redirect instead... default is 302 ... would use a 307 but that's only HTTP/1.1 and would definitely rule out any older browser although may be reconsidered at a later date
* Some white space treatment

Applies to #1198 #135 and post #1174

* Undeprecate a route

* Added a note

Applies to #135

* Remove this route since it won't exist

Applies to #135

* Revert last commit

* Will exist for hook but root of it won't

Applies to #135
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Nov 1, 2017
* Using vanilla JavaScript client-side again. More accurate for single inputs.
* Disable MSIE's native... will test shortly

Loosely related to post OpenUserJS#1174 and followup for OpenUserJS#1210
Martii added a commit that referenced this pull request Nov 1, 2017
* Using vanilla JavaScript client-side again. More accurate for single inputs.
* Disable MSIE's native... will test shortly

Loosely related to post #1174 and followup for #1210

Auto-merge
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Jun 1, 2018
* Remember and recall consents
* Speeds up logging in if we already have it

NOTES:
* Good thing I twiddled with this before :)

Post OpenUserJS#1174 and OpenUserJS#1385 'ish
@Martii Martii mentioned this pull request Jun 1, 2018
Martii added a commit that referenced this pull request Jun 1, 2018
* GDPR2

* Remember and recall consents
* Speeds up logging in if we already have it

NOTES:
* Good thing I twiddled with this before :)

Post #1174 and #1385 'ish

* Fix use case

Applies to #1390

Auto-merge
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Aug 17, 2020
* Using this as a subtle notice that a strategy has been disabled in case someone isn't watching dev
* Fx still doesn't support styling unfortunately *( https://bugzilla.mozilla.org/show_bug.cgi?id=910022 )* so plain disable it. Should cut down on b/w but also possible Code testing increase with visible delineation in dev.

Post OpenUserJS#1174 and reminder-ed in OpenUserJS#1189 ... related to OpenUserJS#1732 OpenUserJS#1733
Martii added a commit that referenced this pull request Aug 17, 2020
* Using this as a subtle notice that a strategy has been disabled in case someone isn't watching dev
* Fx still doesn't support styling unfortunately *( https://bugzilla.mozilla.org/show_bug.cgi?id=910022 )* so plain disable it. Should cut down on b/w but also possible Code testing increase with visible delineation in dev.

Post #1174 and reminder-ed in #1189 ... related to #1732 #1733

Auto-merge
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Sep 11, 2020
* May assist a little on some portables and desktops
* macOS *(Catalina)* doesn't seem to support some attributes in any tested browser
* SM doesn't seem to support some attributes

Post OpenUserJS#1194 OpenUserJS#1174
Martii added a commit that referenced this pull request Sep 11, 2020
* May assist a little on some portables and desktops
* macOS *(Catalina)* doesn't seem to support some attributes in any tested browser
* SM doesn't seem to support some attributes

Post #1194 #1174

Auto-merge
Martii added a commit to Martii/OpenUserJS.org that referenced this pull request Jan 9, 2021
* Custom classes similar to *bootstrap*s
* Apparently a few still don't know how to read, this should help alleviate any excuses/confusion.


Post OpenUserJS#1174
Martii added a commit that referenced this pull request Jan 9, 2021
* Custom classes similar to *bootstrap*s
* Apparently a few still don't know how to read, this should help alleviate any excuses/confusion.


Post #1174

Auto-merge
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. UI Pertains inclusively to the User Interface.
Development

Successfully merging this pull request may close these issues.

1 participant