Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing route directories #237

Merged
merged 1 commit into from
Jul 3, 2014
Merged

Add missing route directories #237

merged 1 commit into from
Jul 3, 2014

Conversation

jerone
Copy link
Contributor

@jerone jerone commented Jul 1, 2014

We have some dead route directories that result in 404's. We can limit them by making redirects.

e.g. https://openuserjs.org/user/preferences -> https://openuserjs.org/user/

I also cleaned up some routes.

Question: should we use the function app_route for all routes? I'm wondering if it causes overhead...

* Add missing route directories;
@Martii
Copy link
Member

Martii commented Jul 1, 2014

What happens if someone wants to make a User Script on those urls? Are we killing any future options?


Btw this probably applies to #135

@jerone
Copy link
Contributor Author

jerone commented Jul 1, 2014

What happens if someone wants to make a User Script on those urls?

I only added one route to the scripts/ directory; the one with an username but without a namespace.
The remaining are part of OUJS urls convention.

Are we killing any future options?

Thus ... no

@sizzlemctwizzle
Copy link
Member

should we use the function app_route for all routes

Yes, it'll make the conversion to Express 4.x (whenever that happens) smoother.

I'm +1 on this (especially the /scripts/:username -> /users/:username/scripts).

sizzlemctwizzle added a commit that referenced this pull request Jul 3, 2014
Add missing route directories
@sizzlemctwizzle sizzlemctwizzle merged commit 35d3600 into OpenUserJS:master Jul 3, 2014
@jerone jerone deleted the app_route branch August 22, 2014 07:19
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Something we do have implemented already but needs improvement upon to the best of knowledge.
Development

Successfully merging this pull request may close these issues.

3 participants