Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize routes (path names) #135

Open
Martii opened this issue Jun 11, 2014 · 4 comments
Open

Normalize routes (path names) #135

Martii opened this issue Jun 11, 2014 · 4 comments
Labels
enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. sooner Sooner would be appreciated.
Milestone
#262

Comments

@Martii
Copy link
Member

Martii commented Jun 11, 2014

Currently /add/scripts and add/lib aren't symmetrical on dev/pro ... along with a few other routes.

  • Best to nip this in the bud early
  • May confuse url linkers
  • May generate extra 404 traffic
  • May generate larger access log files
  • May confuse new contributors
  • Better for documentation
  • Better for discussions
  • Better for code readability

Dependencies:

See also:
@sizzlemctwizzle sizzlemctwizzle mentioned this issue Jun 11, 2014
Merged
@Martii Martii mentioned this issue Jun 18, 2014
Closed
@Martii
Copy link
Member Author

Martii commented Jun 30, 2014

Did we give up on this one?

@jerone
Copy link
Contributor

jerone commented Jun 30, 2014

Suggest to add a landingpage on /add/

@Martii Martii mentioned this issue Jul 1, 2014
Merged
This was referenced Jul 9, 2014
Closed
Merged
Martii referenced this issue in Martii/OpenUserJS.org Jul 16, 2014
Controllers completed, I believe, and some testing on dev... still ha…
af46e15 
…ve libs to do.

* Changed "WARNING" on login page to "CAUTION"... a little too assertive... some users may want their email addy in there.
* Notated some STYLEGUIDE conformance needs
* Notated very short function name(s)
* At least one undefined identifier
@jerone
Copy link
Contributor

jerone commented Aug 23, 2014

Seems to be fixed and symmetrical by now.

@jerone jerone closed this as completed Aug 23, 2014
@jerone jerone removed the sooner label Aug 23, 2014
@Martii
Copy link
Member Author

Martii commented Aug 23, 2014

It's not. A portion of this is described in #250 and some is awaiting in #262

@Martii Martii reopened this Aug 23, 2014
@Martii Martii added this to the #262 milestone Aug 23, 2014
@Martii Martii added the sooner label Aug 24, 2014
@Martii Martii mentioned this issue Sep 29, 2014
Closed
@Martii Martii mentioned this issue Nov 21, 2014
Open
16 tasks
@Martii Martii mentioned this issue Jan 4, 2015
Closed
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Jan 10, 2015
nofollow on all sensitive panels links
3184eb2 
* Some browser toolbars may try to index these while logged in... the "or something" would usually be in robots.txt but OpenUserJS#135 still exists and routes are still in flux so this is what we are left with.

Closes OpenUserJS#340
@Martii Martii mentioned this issue Jan 10, 2015
Merged
Martii pushed a commit to Martii/OpenUserJS.org that referenced this issue Nov 7, 2015
Knock out a TODO in the script controller
34a9e34 
* Merge lib edit get and post routes into one... applies to OpenUserJS#135
* Standardize modelParser to return a url with the username intact just like Edit Script has in Author Tools

Applies to OpenUserJS#135 and post "unrepair" of OpenUserJS#813 and parent OpenUserJS#812
@Martii Martii mentioned this issue Nov 7, 2015
Merged
@Martii Martii mentioned this issue Oct 23, 2017
Closed
Martii added a commit to Martii/OpenUserJS.org that referenced this issue Oct 24, 2017
@Martii
Deprecate some routes
7793beb 
* Normalize on `/login`... keep `register` to ourselves in the code... we already do this a lot... think `index.js` vs `main`.
* Removed one dead route... why would we want to do `/github` to `/`... means to me that it's dead... just return a default 404.
* Fixed one doc send with status 302 to redirect instead... default is 302 ... would use a 307 but that's only HTTP/1.1 and would definitely rule out any older browser although may be reconsidered at a later date
* Some white space treatment

Applies to OpenUserJS#1198 OpenUserJS#135 and post OpenUserJS#1174
@Martii Martii mentioned this issue Oct 24, 2017
Merged
Martii added a commit to Martii/OpenUserJS.org that referenced this issue Oct 24, 2017
@Martii
Undeprecate a route
61ac069 
* Added a note

Applies to OpenUserJS#135
Martii added a commit to Martii/OpenUserJS.org that referenced this issue Oct 24, 2017
@Martii
Remove this route since it won't exist
b67f771 
Applies to OpenUserJS#135
Martii added a commit to Martii/OpenUserJS.org that referenced this issue Oct 24, 2017
@Martii
Revert last commit
09987af 
* Will exist for hook but root of it won't

Applies to OpenUserJS#135
Martii added a commit that referenced this issue Oct 24, 2017
@Martii
Deprecate some routes (#1199)
5c85bfa 
* Deprecate some routes

* Normalize on `/login`... keep `register` to ourselves in the code... we already do this a lot... think `index.js` vs `main`.
* Removed one dead route... why would we want to do `/github` to `/`... means to me that it's dead... just return a default 404.
* Fixed one doc send with status 302 to redirect instead... default is 302 ... would use a 307 but that's only HTTP/1.1 and would definitely rule out any older browser although may be reconsidered at a later date
* Some white space treatment

Applies to #1198 #135 and post #1174

* Undeprecate a route

* Added a note

Applies to #135

* Remove this route since it won't exist

Applies to #135

* Revert last commit

* Will exist for hook but root of it won't

Applies to #135
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Something we do have implemented already but needs improvement upon to the best of knowledge. sooner Sooner would be appreciated.
Milestone
#262
Development

No branches or pull requests
2 participants
@jerone @Martii