Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): uniformize alt value for Orange logos #1630

Merged
merged 2 commits into from
Nov 16, 2022

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented Nov 15, 2022

Description

Reused alt value for Orange logos (created in our Orange navbars) in Navbar and Scrollspy examples, but also in our doc header.
We don't need to mention in the migration guide since it is a value that becomes specific given the usage in a real project.

Motivation & Context

Uniformization in all the documentation.

Types of change

  • Bug fix (non-breaking which fixes an issues)

Live previews

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • All new and existing tests passed

@julien-deramond julien-deramond added v5 docs Improvements or additions to documentation fix labels Nov 15, 2022
@netlify
Copy link

netlify bot commented Nov 15, 2022

Deploy Preview for boosted ready!

Name Link
🔨 Latest commit 69cbec3
🔍 Latest deploy log https://app.netlify.com/sites/boosted/deploys/6374cc1cbcbc9e000867670c
😎 Deploy Preview https://deploy-preview-1630--boosted.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@julien-deramond julien-deramond changed the title fix(docs): uniformize alt for Orange logo fix(docs): uniformize alt value for Orange logo Nov 15, 2022
@julien-deramond julien-deramond changed the title fix(docs): uniformize alt value for Orange logo fix(docs): uniformize alt value for Orange logos Nov 15, 2022
Copy link
Member

@louismaximepiton louismaximepiton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@sonarcloud
Copy link

sonarcloud bot commented Nov 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@julien-deramond julien-deramond merged commit 55aacf8 into main Nov 16, 2022
@julien-deramond julien-deramond deleted the main-jd-fix-alt-for-orange-logo branch November 16, 2022 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to documentation fix v5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants