Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#831): checkboxes display when user accept or deny cookies #856

Merged
merged 4 commits into from
Oct 28, 2021
Merged

fix(#831): checkboxes display when user accept or deny cookies #856

merged 4 commits into from
Oct 28, 2021

Conversation

MewenLeHo
Copy link
Contributor

@MewenLeHo MewenLeHo commented Oct 18, 2021 •
edited by julien-deramond
Loading

Closes #831

@MewenLeHo MewenLeHo self-assigned this Oct 18, 2021
@julien-deramond julien-deramond linked an issue Oct 18, 2021 that may be closed by this pull request
Cookie consent panel checkboxes don't reflect the state of approbation #831
Closed
3 tasks
@MewenLeHo MewenLeHo marked this pull request as draft October 18, 2021 14:26
@MewenLeHo MewenLeHo marked this pull request as ready for review October 18, 2021 15:01
@MewenLeHo MewenLeHo force-pushed the main-mewenleho-checkboxes-cookies-consent branch from 4151bc3 to 363808f Compare October 18, 2021 15:12
julien-deramond
julien-deramond requested changes Oct 19, 2021
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition, if

Google Tag Manager is well authorized but the checkbox isn't checked

site/assets/js/tac.js Outdated Show resolved Hide resolved
site/assets/js/tac.js Show resolved Hide resolved
julien-deramond
julien-deramond requested changes Oct 20, 2021
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package-lock.json is commited and shouldn't be.

site/assets/js/tac.js Outdated Show resolved Hide resolved
@julien-deramond
Copy link
Member

In addition, if

* I authorize all cookies in the bottom panel

* I go to http://localhost:9001/docs/5.1/about/cookies/

Google Tag Manager is well authorized but the checkbox isn't checked

If it is too complicated to tackle in this PR, you can create another issue.

@MewenLeHo MewenLeHo force-pushed the main-mewenleho-checkboxes-cookies-consent branch 3 times, most recently from 5eb940a to 6879ddf Compare October 20, 2021 12:43
julien-deramond
julien-deramond reviewed Oct 26, 2021
View reviewed changes
Copy link
Member

@julien-deramond julien-deramond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the fact that we are using only one tracking service, this modification should be enough. We'll try to find something more generic if we have to handle cookies from several services.

site/assets/js/tac.js Show resolved Hide resolved
@MewenLeHo MewenLeHo force-pushed the main-mewenleho-checkboxes-cookies-consent branch from de99fe6 to 203b044 Compare October 28, 2021 13:03
@julien-deramond julien-deramond merged commit 18fb2da into main Oct 28, 2021
@julien-deramond julien-deramond deleted the main-mewenleho-checkboxes-cookies-consent branch October 28, 2021 13:31
@julien-deramond julien-deramond mentioned this pull request Oct 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-deramond julien-deramond julien-deramond approved these changes

Assignees

@MewenLeHo MewenLeHo

Labels
fix v5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cookie consent panel checkboxes don't reflect the state of approbation
2 participants
@MewenLeHo @julien-deramond