Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Disable email-edit button for disallowed users #457

Closed
fmigneault opened this issue Aug 4, 2021 · 0 comments · Fixed by #493
Closed

[BUG] Disable email-edit button for disallowed users #457

fmigneault opened this issue Aug 4, 2021 · 0 comments · Fixed by #493
Assignees
@fmigneault
Labels
bug Problem, error, or invalid behaviour good first issue Good for newcomers help wanted ui Something related to the UI operations or display

Comments

@fmigneault
Copy link
Collaborator

Describe the bug
As highlighted by #443, button to edit the email of a user (anonymous in that case) is enabled although it should not because it is a reserved keyword user.

Expected behavior
The same operation as the name-edit button must be done for those special users to disable the button to edit email.

The API already behaves correctly by blocking the operation. The UI simply reports and error where it could be avoided with a lock-icon and message.
@fmigneault fmigneault added the bug Problem, error, or invalid behaviour label Aug 4, 2021
@fmigneault fmigneault self-assigned this Aug 4, 2021
@fmigneault fmigneault added good first issue Good for newcomers help wanted ui Something related to the UI operations or display labels Aug 4, 2021
fmigneault added a commit that referenced this issue Jan 6, 2022
@fmigneault
improve UI buttons/icons/message for disallowed edits (fixes #434, fixes
db13492 
 #457)
@fmigneault fmigneault mentioned this issue Jan 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fmigneault fmigneault

Labels
bug Problem, error, or invalid behaviour good first issue Good for newcomers help wanted ui Something related to the UI operations or display
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

UI fixes Ouranosinc/Magpie
1 participant
@fmigneault