Support time-sampled computed primvars #1455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
similar to SamplePrimvar()
computed primvars. Also added a VtValue specialization of HdResampleNeighbors(), for resampling an HdTimeSampleArray of VtValue's.
If the value type can't be interpolated, just hold the previous sample's value rather than producing a runtime warning.
This uses a simple computation to test the handling of time samples and interpolating input samples.
|
Filed as internal issue #USD-6575 |
…ghbors(). - Remove the USD dependency and just directly specify the types we expect to interpolate. - Replace the BOOST_PP_SEQ_FOR_EACH usage with variadic templates. - Fix some inconsistent code formatting.
This is similar to related methods such as SamplePrimvar().
This removes the hardcoded static capacity of 4, and templates SampledValueStore to use the static capacity specified by the client code. Additionally, the internal _ExecuteSampledComputations() method is now templated so that the static capacity of its value store arrays are also controlled by the client. Factored out some parts of the _ExecuteSampledComputations() implementation that do not rely on the template parameter. This limits the amount of code moved into the header (in particular, this also hides the usage of internal classes such as Hd_ExtComputationContextInternal).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
This adds support for evaluating time samples of computed primvars (ExtComputation) - the primary use case is motion blur for skinned primitives.
ExtComputationscene input, similar toSamplePrimvar()and related methodsSampleExtComputationInput()for the skinning computation.HdExtComputationUtils::SampleComputedPrimvarValues()for evaluating time samples of the computed primvars, along with a basic unit testA couple notes from prior discussions with @rajabala
SamplePrimvar()HdTimeSampleArrayinextComputationUtils.his a bit unfortunate, but I'm not sure we want to turnSampleComputedPrimvarValuesinto a templated function