Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcoap_forward_proxy: No test provided #20910

Open
maribu opened this issue Oct 14, 2024 · 0 comments
Open

gcoap_forward_proxy: No test provided #20910

maribu opened this issue Oct 14, 2024 · 0 comments
Assignees

Comments

@maribu
Copy link
Member

maribu commented Oct 14, 2024

Description

The module gcoap_forward_proxy has no test coverage, not even compile testing.

Steps to reproduce the issue

Run USEMODULE=gcoap_forward_proxy BOARD=atmega256rfr2-xpro make -C examples/gcoap. It will fail to compile (at least on Ubuntu/Debian systems with the prehistoric AVR toolchain) with:

**sys/net/application_layer/gcoap/forward_proxy.c:356:23: error:comparison between signed and unsigned integer expressions [-Werror=sign-compare]
     for (int i = 0; i < client_pkt->options_len; i++) {
                       ^**

Expected results

The module would compile on all platforms, at least with the toolchain used in riot/riotbuild, as it is compile tested by the CI.

Actual results

It fails to compile on some platforms.

Versions

All up to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants