Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys/crypto/modes/ccm: handle input_len = 0 #13848

Merged
merged 2 commits into from
Apr 14, 2020
Merged

sys/crypto/modes/ccm: handle input_len = 0 #13848

merged 2 commits into from
Apr 14, 2020

Conversation

fjmolinas
Copy link
Contributor

Contribution description

This PR is split from #13149, it allows handling handling of messages with no plaintext.

Testing procedure

A test case has been added, sys_crpyto tests still pass:

make -C tests/sys_crypto/ all test

Help: Press s to start test, r to print it is ready
READY
s
START
main(): This is RIOT! (Version: 2020.04-devel-2051-ga3dbc-pr_ccm_no_plaintext)
..................................
OK (34 tests)
  • green murdock

Issues/PRs references

#13149

@fjmolinas fjmolinas added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: crypto Area: Cryptographic libraries CI: run tests If set, CI server will run tests on hardware for the labeled PR labels Apr 9, 2020
fjmolinas
fjmolinas commented Apr 10, 2020
View reviewed changes
sys/crypto/modes/ccm.c Outdated Show resolved Hide resolved
@fjmolinas
Copy link
Contributor Author

The test failure is unrelated:

--- run_test job results (2 failed, 53 passed, 55 total):
    failed:
    tests/netstats_l2/esp32-wroom-32:gnu
    tests/pkg_ubasic/esp32-wroom-32:gnu

I'll re-trigger the build with no tests.

@fjmolinas fjmolinas removed the CI: run tests If set, CI server will run tests on hardware for the labeled PR label Apr 10, 2020
@leandrolanzieri leandrolanzieri self-assigned this Apr 14, 2020
leandrolanzieri
leandrolanzieri approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good and tests are passing. ACK

@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 14, 2020
@leandrolanzieri leandrolanzieri merged commit b4655f6 into RIOT-OS:master Apr 14, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.04 milestone Apr 17, 2020
@leandrolanzieri leandrolanzieri mentioned this pull request Apr 20, 2020
Merged
@leandrolanzieri
Copy link
Contributor

Backport provided in #13904

@fjmolinas fjmolinas deleted the pr_ccm_no_plaintext branch July 31, 2020 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@mtausig mtausig Awaiting requested review from mtausig

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees

@leandrolanzieri leandrolanzieri

Labels
Area: crypto Area: Cryptographic libraries CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: needs backport Integration Process: The PR is required to be backported to a release or feature branch Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Reviewed: 5-documentation The documentation details of the PR were reviewed according to the maintainer guidelines Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2020.04
Development

Successfully merging this pull request may close these issues.
2 participants
@fjmolinas @leandrolanzieri