Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys/crypto/modes/ccm: handle input_len = 0 [backport 2020.04] #13904

Merged
merged 2 commits into from
Apr 20, 2020
Merged

sys/crypto/modes/ccm: handle input_len = 0 [backport 2020.04] #13904

merged 2 commits into from
Apr 20, 2020

Conversation

leandrolanzieri
Copy link
Contributor

Backport of #13848

Contribution description

This PR is split from #13149, it allows handling handling of messages with no plaintext.

Testing procedure

A test case has been added, sys_crpyto tests still pass:

make -C tests/sys_crypto/ all test

Help: Press s to start test, r to print it is ready
READY
s
START
main(): This is RIOT! (Version: 2020.04-devel-2051-ga3dbc-pr_ccm_no_plaintext)
..................................
OK (34 tests)
  • green murdock

Issues/PRs references

#13149

@fjmolinas @leandrolanzieri
sys/crypto/modes/ccm: accept input_len=0
6633105 
CCM may be used on messages with no plaintext data.

(cherry picked from commit 8372286)
@fjmolinas @leandrolanzieri
tests/sys_crypto/tests-crypto-modes-ccm: add test for input_len=0
409ae9e 
(cherry picked from commit 7a39e2e)
@leandrolanzieri leandrolanzieri added Area: crypto Area: Cryptographic libraries CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Apr 20, 2020
@leandrolanzieri leandrolanzieri mentioned this pull request Apr 20, 2020
Merged
fjmolinas
fjmolinas approved these changes Apr 20, 2020
View reviewed changes
Copy link
Contributor

@fjmolinas fjmolinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK!

@leandrolanzieri leandrolanzieri merged commit 8026092 into RIOT-OS:2020.04-branch Apr 20, 2020
@leandrolanzieri leandrolanzieri deleted the backport/2020.04/pr_ccm_no_plaintext branch April 20, 2020 08:24
@leandrolanzieri leandrolanzieri added this to the Release 2020.04 milestone Apr 20, 2020
@leandrolanzieri leandrolanzieri mentioned this pull request Apr 24, 2020
Closed
81 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjmolinas fjmolinas fjmolinas approved these changes

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@smlng smlng Awaiting requested review from smlng

Assignees
No one assigned
Labels
Area: crypto Area: Cryptographic libraries CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Process: release backport Integration Process: The PR is a release backport of a change previously provided to master Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2020.04
Development

Successfully merging this pull request may close these issues.
2 participants
@leandrolanzieri @fjmolinas