Fix issues with rare's process launcher #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
loathingKernel
commented
Sep 16, 2024
•
loathingKernel
commented
- RareLauncher: fix cloud sync dialog not opening on pyside6 and blocking execution
- workflows: remove pywebview from packages
- RareLauncher: check before deleting CloudSyncDialog
- PathEdit: remove implicit use of shlex
- LaunchSettings: separate command input widget from the arguments widget
- project: update requirements.txt
Quoting the string prevents QCompleter from completing paths properly. It also causes issues with paths on Windows, such as failing because of improper driver letters.
Since we do not want to quote the command string when returned from the path dialog, for the reasons stated before, or the user might forget to quote the command string when setting it, separate it from the rest of the command and add a separate input widget for the arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.