Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all.equal ignore row order improperly handle NAs #4422

Closed
jangorecki opened this issue May 4, 2020 · 0 comments · Fixed by #4423
Closed

all.equal ignore row order improperly handle NAs #4422

jangorecki opened this issue May 4, 2020 · 0 comments · Fixed by #4423
Assignees
@jangorecki
Labels
bug
Milestone
1.13.0

Comments

@jangorecki
Copy link
Member 

d1 = data.table(a=1:2, b=c(1L,NA))
d2 = data.table(a=1:2, b=1:2)
all.equal(d1, d2, ignore.row.order=TRUE)
#[1] TRUE
@jangorecki jangorecki added the bug label May 4, 2020
@jangorecki jangorecki added this to the 1.12.9 milestone May 4, 2020
jangorecki added a commit that referenced this issue May 4, 2020
@jangorecki
all.equal ignore row order, fix #4422
d52e6d1
@jangorecki jangorecki mentioned this issue May 4, 2020
Merged
@jangorecki jangorecki self-assigned this May 4, 2020
@jangorecki jangorecki modified the milestones: 1.12.11, 1.12.9 May 27, 2020
@mattdowle mattdowle modified the milestones: 1.12.11, 1.12.9 Jun 2, 2020
mattdowle pushed a commit that referenced this issue Jun 2, 2020
@jangorecki
all.equal ignore row order, fix #4422 (#4423)
738289d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jangorecki jangorecki

Labels
bug
Projects
None yet
Milestone
1.13.0
Development

Successfully merging a pull request may close this issue.

all.equal ignore row order, fix #4422 Rdatatable/data.table
2 participants
@mattdowle @jangorecki