Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

all.equal ignore row order, fix #4422 #4423

Merged
merged 3 commits into from
Jun 2, 2020
Merged

all.equal ignore row order, fix #4422 #4423

merged 3 commits into from
Jun 2, 2020

Conversation

jangorecki
Copy link
Member

closes #4422

@codecov
Copy link

codecov bot commented May 4, 2020

Codecov Report

Merging #4423 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4423      +/-   ##
==========================================
- Coverage   99.60%   99.60%   -0.01%     
==========================================
  Files          72       72              
  Lines       13970    13968       -2     
==========================================
- Hits        13915    13913       -2     
  Misses         55       55              
Impacted Files Coverage Δ
R/setops.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1f73cf...ea6e8a0. Read the comment docs.

R/setops.R Outdated Show resolved Hide resolved
@jangorecki jangorecki added this to the 1.12.9 milestone May 31, 2020
@mattdowle mattdowle merged commit 738289d into master Jun 2, 2020
@mattdowle mattdowle deleted the all.equal-row branch June 2, 2020 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

all.equal ignore row order improperly handle NAs
3 participants