.SDcols peeling outer ( and edge case of :, and a logical of diff length #4470
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4470 +/- ##
=========================================
Coverage ? 99.60%
=========================================
Files ? 72
Lines ? 13920
Branches ? 0
=========================================
Hits ? 13865
Misses ? 55
Partials ? 0
Continue to review full report at Codecov.
|
|
Great. The news item could be better. I try and include a code example (it doesn't have to be a reproducible example for a news item; just show the syntax), and where an error message is referred to, include the text of the error message. That way when a user searches for the error message, they find the news item. |
jangorecki
changed the title
R/data.table.R
Outdated
| @@ -1016,6 +1018,7 @@ replace_dot_alias = function(e) { | |||
| if (anyNA(.SDcols)) | |||
| stop(".SDcols missing at the following indices: ", brackify(which(is.na(.SDcols)))) | |||
| if (is.logical(.SDcols)) { | |||
| if (length(.SDcols)!=length(x)) warning("logical vector in .SDcols should have equal length to number of columns in input table") | |||
There was a problem hiding this comment.
We usually try and be even more helpful in error messages by including the values of length(x) and length(.SDcols) in the message.
closes #4231 and #4115