Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Sync for Reddit): Add Fix video downloads patch #710

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

1fexd
Copy link

@1fexd 1fexd commented Oct 4, 2024

Re-implements MPD manifest interpretation to fix video track not being saved - see ReVanced/revanced-patches#3739

@oSumAtrIX oSumAtrIX changed the title fix(sync): Reddit video downloader feat(Sync for Reddit): Add Fix video downloads patch Oct 4, 2024
Copy link
Member

@oSumAtrIX oSumAtrIX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is a reimplementation of the parser needed? Can the existing parser in Sync not be fixed for that?

@1fexd
Copy link
Author

1fexd commented Oct 4, 2024

Why is a reimplementation of the parser needed? Can the existing parser in Sync not be fixed for that?

Just rewriting it as an integrations patch was less tedious and allowed me to easily test it standalone

@oSumAtrIX oSumAtrIX self-requested a review October 5, 2024 23:20
@oSumAtrIX oSumAtrIX merged commit 888de49 into ReVanced:dev Oct 17, 2024
1 check passed
Copy link

welcome bot commented Oct 17, 2024

Thank you for contributing to ReVanced. Join us on Discord to receive a role for your contribution.

github-actions bot pushed a commit that referenced this pull request Oct 17, 2024
# [1.16.0-dev.8](v1.16.0-dev.7...v1.16.0-dev.8) (2024-10-17)

### Features

* **Sync for Reddit:** Add `Fix video downloads` patch ([#710](#710)) ([888de49](888de49))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants