feat(Sync for Reddit): Add Fix video downloads patch
#3739
Merged
+84
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oSumAtrIX
changed the title
Fix video downloads patch
oSumAtrIX
requested changes
Oct 4, 2024
...revanced/patches/reddit/customclients/syncforreddit/fix/video/FixRedditVideoDownloadPatch.kt
Outdated
Show resolved
Hide resolved
...revanced/patches/reddit/customclients/syncforreddit/fix/video/FixRedditVideoDownloadPatch.kt
Outdated
Show resolved
Hide resolved
...revanced/patches/reddit/customclients/syncforreddit/fix/video/FixRedditVideoDownloadPatch.kt
Outdated
Show resolved
Hide resolved
...revanced/patches/reddit/customclients/syncforreddit/fix/video/FixRedditVideoDownloadPatch.kt
Outdated
Show resolved
Hide resolved
...revanced/patches/reddit/customclients/syncforreddit/fix/video/FixRedditVideoDownloadPatch.kt
Outdated
Show resolved
Hide resolved
...s/reddit/customclients/syncforreddit/fix/video/fingerprints/RedditVideoRequestFingerprint.kt
Outdated
Show resolved
Hide resolved
...revanced/patches/reddit/customclients/syncforreddit/fix/video/FixRedditVideoDownloadPatch.kt
Outdated
Show resolved
Hide resolved
...revanced/patches/reddit/customclients/syncforreddit/fix/video/FixRedditVideoDownloadPatch.kt
Outdated
Show resolved
Hide resolved
…forreddit/fix/video/FixRedditVideoDownloadPatch.kt Co-authored-by: oSumAtrIX <[email protected]>
…forreddit/fix/video/FixRedditVideoDownloadPatch.kt Co-authored-by: oSumAtrIX <[email protected]>
oSumAtrIX
reviewed
Oct 7, 2024
.../app/revanced/patches/reddit/customclients/syncforreddit/fix/video/FixVideoDownloadsPatch.kt
Outdated
Show resolved
Hide resolved
oSumAtrIX
reviewed
Oct 7, 2024
.../app/revanced/patches/reddit/customclients/syncforreddit/fix/video/FixVideoDownloadsPatch.kt
Outdated
Show resolved
Hide resolved
oSumAtrIX
reviewed
Oct 7, 2024
.../app/revanced/patches/reddit/customclients/syncforreddit/fix/video/FixVideoDownloadsPatch.kt
Outdated
Show resolved
Hide resolved
oSumAtrIX
reviewed
Oct 14, 2024
.../app/revanced/patches/reddit/customclients/syncforreddit/fix/video/FixVideoDownloadsPatch.kt
Outdated
Show resolved
Hide resolved
oSumAtrIX
approved these changes
Oct 17, 2024
|
Thanks |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 17, 2024
# [4.17.0-dev.9](v4.17.0-dev.8...v4.17.0-dev.9) (2024-10-17) ### Features * **Sync for Reddit:** Add `Fix video downloads` patch ([#3739](#3739)) ([a47ee38](a47ee38))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug in Sync Reddit which resulted in only the audio track being saved when downloading videos from Reddit due to a weird check for the video track - I've gone ahead and added a integrations-patch which re-implements the functionality, bypassing the existing implementation (ReVanced/revanced-integrations#710)