feat(YouTube): Reorganize settings to be less cluttered

[LisoUseInAIKyrios]

Feature description

Right now there are 5 sub-menus in the ReVanced settings menu (Ads, Interaction, Layout, Misc, Video), but the majority of the settings are in Layout.

The Layout menu has over 55 setting switches and 9 additional sub-menus. 2/3 of all settings are in that single menu.

It would be helpful to come up with a better way to organize the settings.

Motivation

It could be faster and more intuitive to find individual settings.

Acknowledgements

• This issue is not a duplicate of an existing feature request.
• I have chosen an appropriate title.
• All requested information has been provided properly.

[oSumAtrIX]

Settings can be separated by category as they are done in the Twitch patches. Some changes are currently pending in our branches which we may want to consider before having to deal with merge conflicts

[LisoUseInAIKyrios]

A solution can be to break up layout into a multiple sub-menus under 'ReVanced' such as:

• Shorts (everything Shorts related)
• Feed layout (settings specific to home feed, subscription feed, and recommended videos)
• Player layout (all layout items of the player and player comment area)
• Other layout (all other layout items not in the categories above)

And maybe move some of the layout sub-menus up a level to their own ReVanced sub-menu. A few candidates might be:

• Seekbar
• Alternative thumbnails

[LisoUseInAIKyrios]

A few other related ideas to maybe or maybe not consider:

• move the root menus (ReVanced / Return YouTube Dislike / SponsorBlock / GMS Core) to the top of the settings menu and not the bottom. The ReVanced settings are changed more often than the stock YouTube settings, and it's annoying to always scroll thru the mostly junk YT settings
• move RYD / SponsorBlock into the ReVanced menu. OR, move the ReVanced sub menus out into root level menus (one less menu to navigate into).
• move the sub-menus to the top of each preference screen and not the bottom (so the sub-menus in Layout would be first, and not last). Would require less scrolling for the deepest menus.

[LisoUseInAIKyrios]

Some changes are currently pending in our branches which we may want to consider before having to deal with merge conflicts

This is not a priority since it's only organization, nor is it difficult to do. It's only a matter of deciding how to organize it all.

[oSumAtrIX]

A few other related ideas to maybe or maybe not consider:

• move the root menus (ReVanced / Return YouTube Dislike / SponsorBlock / GMS Core) to the top of the settings menu and not the bottom. The ReVanced settings are changed more often than the stock YouTube settings, and it's annoying to always scroll thru the mostly junk YT settings
• move RYD / SponsorBlock into the ReVanced menu. OR, move the ReVanced sub menus out into root level menus (one less menu to navigate into).
• move the sub-menus to the top of each preference screen and not the bottom (so the sub-menus in Layout would be first, and not last). Would require less scrolling for the deepest menus.

So, one of the PRs is currently moving everything under a ReVanced submenu. Since we abstracted the settings patches, the abstraction asks to provide a file where to inject the "root" setting item, and then we can specify the setting item to open a setting menu with our patch settings. Having RYD, SB and GmsCore in their own menu made sense back then for Vanced, but with our design they are treated as regular patches. RYD, SB and GmsCore are therefor as per current design added under Misc.

Going forward with this issue, they can be reorganized according to the proposed design, but I'd say to always inject at max 1 ReVanced setting item into each app, and then add patches under that submenu and never outside of it.

[oSumAtrIX]

Here is a reference to the "root" preference

revanced-patches/src/main/kotlin/app/revanced/patches/shared/settings/AbstractSettingsResourcePatch.kt

Line 25 in dfb6b1e

private val rootPreference: Pair<IntentPreference, String>? = null,