feat(YouTube): Reorganize settings menu

[LisoUseInAIKyrios]

This PR reorganizes the YouTube ReVanced settings.

Changes made:

• Breaks apart the huge Layout menu into 3 separate menus: Feed, Player, General layout
• Moves Shorts, Seekbar, Swipe controls, Alternative thumbnails, Return You Tube Dislike, SponsorBlock up to top level menus under ReVanced Settings
• Removes the horizontal separators from the settings
• Removes the summary text of the root ReVanced menu and the first level of sub menus (Player, Seekbar, etc)
• Moves the ReVanced Settings menu and all sub-menus to the top of each preference list (and not the bottom)

Screenshots:

Root menu
Feed
Player
General layout
Seekbar
Misc

Integration changes

[MarcaDian]

It might be nice to also move Alternative thumbnails up a level, but then all of its preferences would be sorted alphabetically and it becomes more difficult to understand

The only issue I see, is some preferences are not grouped together (such as the seekbar custom color switch and text color). This is because the first and second menu depths are sorted at runtime by Integrations, which causes the related preferences to become reordered. Right now the only way to group preferences together is adding all of them to their own submenu that is 2 or more levels deep.

The best solution to this problem would be to change the sorting to the first menu depths:
revanced-integrations\app\src\main\java\app\revanced\integrations\shared\settings\preference\AbstractPreferenceFragment.java
Utils.sortPreferenceGroupByTitle(getPreferenceScreen(), 2);
to
Utils.sortPreferenceGroupByTitle(getPreferenceScreen(), 1);

[LisoUseInAIKyrios]

The best solution to this problem would be to change the sorting to the sub-item above: revanced-integrations\app\src\main\java\app\revanced\integrations\shared\settings\preference\AbstractPreferenceFragment.java Utils.sortPreferenceGroupByTitle(getPreferenceScreen(), 2); to Utils.sortPreferenceGroupByTitle(getPreferenceScreen(), 1);

That would leave the sub-menus completely unsorted. So Player layout and all the shared menus would be a random list of the preferences in the order the patches executed. Not ideal.

The reason the 3rd and deeper menus are unsorted is because those menus are added entirely by one patch and it can specify an ordering that makes sense without the issue of intermixing preferences from different patches.

[MarcaDian]

The only issue I see, is some preferences are not grouped together in the menu lists (such as the seekbar custom color switch and text color, which do not appear above/below each other)

Now I’m working on localizing settings for other languages, this is currently a very serious problem, since the items in one patch are scattered throughout the list, but should be one after another, for example, Spoof app version and selecting this version.
Can we expect a quick fix for this issue or is it not a priority? I wouldn’t want to disable sorting, otherwise I’ll have to, since the user’s experience suffers
A temporary solution can only be to translate these menu items into one value.

[LisoUseInAIKyrios]

A possible crutch for now is to translate the related settings so they use titles that sort next to each other.

For example, Spoof app version and Spoof app version target appear correct since their sorted order places them next to each other. But maybe this isn't so easy with some languages.

[MarcaDian]

Maybe
SettingsPatch.PreferenceScreen.LAYOUT_PLAYER.addPreferences(SwitchPreference("revanced_gradient_loading_screen")) to Feed layout or Other layout?

[LisoUseInAIKyrios]

Maybe SettingsPatch.PreferenceScreen.LAYOUT_PLAYER.addPreferences(SwitchPreference("revanced_gradient_loading_screen")) to Feed layout or Other layout?

Yeah I think the feed layout is better.

[MarcaDian]

SwitchPreference("revanced_hide_video_quality_menu_footer"),

I know this is a component of hide components patch, but this also applies to the VIDEO section.

[LisoUseInAIKyrios]

SwitchPreference("revanced_hide_video_quality_menu_footer"),

I know this is a component of hide components patch, but this also applies to the VIDEO section.

Yeah since the 'old video quality layout' is already in Video as well.

A possibility is to remove the setting, and instead it hides the footer only if 'remember video quality' is turned on. But maybe someone wants to hide the footer even if remember is not turned on.

[MarcaDian]

SettingsPatch.PreferenceScreen.LAYOUT_PLAYER.addPreferences(
            SwitchPreference("revanced_remove_viewer_discretion_dialog")
        )

Also maybe to FEED_LAYOUT or OTHER_LAYOUT, becaouse this dialog apear from feed

---

SettingsPatch.PreferenceScreen.LAYOUT_PLAYER.addPreferences(
            SwitchPreference("revanced_disable_rolling_number_animations")
        )

OTHER_LAYOUT ?

---

SettingsPatch.PreferenceScreen.LAYOUT_PLAYER.addPreferences(
            PreferenceScreen(
                key = "revanced_swipe_controls_preference_screen",
                preferences = setOf(
                    SwitchPreference("revanced_swipe_brightness"),
                    SwitchPreference("revanced_swipe_volume"),
                    SwitchPreference("revanced_swipe_press_to_engage"),
                    SwitchPreference("revanced_swipe_haptic_feedback"),
                    SwitchPreference("revanced_swipe_save_and_restore_brightness"),
                    TextPreference("revanced_swipe_overlay_timeout", inputType = InputType.NUMBER),
                    TextPreference("revanced_swipe_text_overlay_size", inputType = InputType.NUMBER),
                    TextPreference("revanced_swipe_overlay_background_alpha", inputType = InputType.NUMBER),
                    TextPreference("revanced_swipe_threshold", inputType = InputType.NUMBER)
                ),
            )
        )

Maybe move to root menu?

---

SettingsPatch.PreferenceScreen.LAYOUT_PLAYER.addPreferences(
            PreferenceScreen(
                "revanced_copy_video_url_preference_screen",
                preferences = setOf(
                    SwitchPreference("revanced_copy_video_url"),
                    SwitchPreference("revanced_copy_video_url_timestamp")
                )
            )
        )

Why revanced_copy_video_url under PreferenceScreen ? 2 almost identical menu items.
This also applies to External Downoader

---

SettingsPatch.PreferenceScreen.LAYOUT_PLAYER.addPreferences(
            PreferenceScreen(
                "revanced_comments_preference_screen",
                preferences = setOf(
                    SwitchPreference("revanced_hide_comments_section"),
                    SwitchPreference("revanced_hide_preview_comment")
                )
            )
        )

Comments section are not very suitable for LAYOUT_PLAYER, maybe to OTHER_LAYOUT?

---

And in general, the section OTHER_LAYOUT is not needed, its menu items can be moved to MISC or to FEED. Instead of it, you can move the Swipe controls and Navigation buttons to the root

[LisoUseInAIKyrios]

Rolling numbers appear only in the regular video player and nowhere else.

I think copy url buttons could be moved out from a sub-menu into Player layout, especially since then settings are simple and both switches are named almost the same.

I think external download is better to keep under its own sub menu, as it's easier to understand when it's separate and all settings are self contained (the feature is commonly confusing new users).

Swipe controls could go in a root menu, but it has issues with the alphabetic sorting making the swipe controls preferences confusing. Until preference groups are added I think it's better to leave it under player just to fix the UI ordering. edit: Screen sorting issue is figured out, and Swipe controls are now a root menu.

[LisoUseInAIKyrios]

A possible short term partial fix for the shorting issue, is to repurpose the basically unused PreferenceScreen key to indicate how that screen should be sorted.

Use preference screen keys with something like "revanced_whatever_screen_sort_title"
"revanced_whatever_screen_sort_key"
"revanced_whatever_screen_sort_ignore"

Where the "sort_*" suffix indicates how to sort the screen.

Where it sorts by the translated title, sorts by preference key, or remains unsorted and leaves everything as-is in the order Patches specified.

Since the screen keys are not actually used and can be any value, it would fix the issue of moving Alternative Thumbnails and Swipe Controls to the root menu. It would also allow any sub menu to be sorted by runtime title, if a patch wants.

This won't fix the issue of menus with preferences from different patches getting mixed up from alphabetical sort (the solution to that is add Preference groups), but it would fix all other sorting issues.

edit: Preference Screen sorting options was added to this PR

[MarcaDian]

SwitchPreference("revanced_hide_community_guidelines"),
to

        SettingsPatch.PreferenceScreen.LAYOUT_PLAYER.addPreferences(
            PreferenceScreen(
                "revanced_comments_preference_screen",
                preferences = setOf(
                    SwitchPreference("revanced_hide_comments_section"),
                    SwitchPreference("revanced_hide_preview_comment")
                )
            )
        )

Because this toggle hide the guidelines message from top of Comments section?

[LisoUseInAIKyrios]

Because this toggle hide the guidelines message from top of Comments section?

Not sure on that one. It is the comment section, but it's not a comment itself. I guess it could go either place.

[LisoUseInAIKyrios]

Adding a sort ordering for the PreferenceScreen was fairly simple.

Alternatively it could use an <extra /> added to the Preference XML and include arbitrary data, but that appears to require referencing an extra XML file or requires adding a new attribute type to attrs.xml. Since the Screen key is unused, for now it's a lot simpler to repurpose the key.

[LisoUseInAIKyrios]

And in general, the section OTHER_LAYOUT is not needed, its menu items can be moved to MISC or to FEED. Instead of it, you can move the Swipe controls and Navigation buttons to the root

The stuff in Other layout is layout related but not specific to the feed or the player. The Misc menu does not contain anything layout related.

I think the navigation buttons menu are too small of a feature to make top level, especially if giving up the more general other layout.

[LisoUseInAIKyrios]

I think this is just about ready.

Maybe merge this before the next release?

Could use the settings change announcement to also mention that playback history is currently broken.

[oSumAtrIX]

I'll review it once I have time. I'll merge before next release