Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TypeScript): enable 'noUnusedLocals' options #1969

Closed
tetsuharuohzeki opened this issue Sep 23, 2016 · 9 comments
Closed

feat(TypeScript): enable 'noUnusedLocals' options #1969

tetsuharuohzeki opened this issue Sep 23, 2016 · 9 comments

Comments

@tetsuharuohzeki
Copy link
Contributor

tetsuharuohzeki commented Sep 23, 2016

  • This would be useful to clean up our codes.
  • We detect unused variables at compile time.
  • We can replace tslint's no-unused-variable.
@tetsuharuohzeki
Copy link
Contributor Author

And we could be able to disable tslint's no-unused-variable rule. It might be decrease the time to run tslint

@kwonoj
Copy link
Member

kwonoj commented Sep 23, 2016

@saneyuki , please aggregate into single issue to track enabling TS 2.0 specific features. I don't think it's need to be tracked as separated issue for each options.

@kwonoj
Copy link
Member

kwonoj commented Sep 23, 2016

Long-hanging task tracking issue #1837 can be used for those purpose.

@tetsuharuohzeki
Copy link
Contributor Author

@kwonoj Ah, okay. I'll change title and description of #1837

@tetsuharuohzeki
Copy link
Contributor Author

Duplicated #1837

@tetsuharuohzeki tetsuharuohzeki changed the title WAITING FOR TSC 2.0: enable 'noUnusedLocals' options feat(TypeScript): enable 'noUnusedLocals' options Oct 25, 2016
@tetsuharuohzeki
Copy link
Contributor Author

I'll reopen as a separated tracking issue.

@tetsuharuohzeki
Copy link
Contributor Author

If we replace tslint's no-unused-variable, the exec time of tslint will be decreased.

The result of time npm run lint_src

env: MacBook Pro (Retina, 15-inch, Mid 2014), 2.8 GHz Intel Core i7

real user sys
before 6.85 6.97 0.28
after 5.26 5.16 0.29

@kwonoj
Copy link
Member

kwonoj commented Nov 19, 2016

as this issue is discussed in #2104 and concluded to not to introduce compiler level option, I believe issue can be closed.

@kwonoj kwonoj closed this as completed Nov 19, 2016
@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants