Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(linting): remove needless members detected by noUnusedLocals #2125

Closed

Conversation

tetsuharuohzeki
Copy link
Contributor

Description:

Related issue (if exists):

@tetsuharuohzeki
Copy link
Contributor Author

rebased!

@coveralls
Copy link

coveralls commented Nov 15, 2016

Coverage Status

Coverage decreased (-0.004%) to 97.681% when pulling dc57144 on saneyuki:rm-unused-locals into e0cf882 on ReactiveX:master.

@tetsuharuohzeki
Copy link
Contributor Author

Coverage decreased (-0.1%) to 97.59% when pulling

Ugh, mysterious down is again 😢

@coveralls
Copy link

coveralls commented Nov 30, 2016

Coverage Status

Coverage decreased (-0.004%) to 97.682% when pulling 36a01af on saneyuki:rm-unused-locals into 128fb9c on ReactiveX:master.

@coveralls
Copy link

coveralls commented Dec 13, 2016

Coverage Status

Coverage decreased (-0.004%) to 97.682% when pulling 36a01af on saneyuki:rm-unused-locals into 128fb9c on ReactiveX:master.

@benlesh
Copy link
Member

benlesh commented Feb 21, 2017

@saneyuki ... I'm so sorry. Given that this PR has gone stale, and there hasn't been much interest from the rest of the team. I'm going to close it for now. cc @kwonoj just in case.

@benlesh benlesh closed this Feb 21, 2017
@tetsuharuohzeki tetsuharuohzeki deleted the rm-unused-locals branch February 21, 2017 05:04
@tetsuharuohzeki
Copy link
Contributor Author

@Blesh

okay. I will open a new pull request which is more break downed.**

@lock
Copy link

lock bot commented Jun 6, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants