Bring next branch up to date
#2376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The max line length is set to 150 in 'tslint.json'. In specific regions, it is desirable to allow longer lines, so these regions should be wrapped in comments like the following: ```js // Max line length enforced here. /* tslint:disable:max-line-length */ // Max line length NOT enforced here. /* tslint:enable:max-line-length */ <-- CORRECT // Max line length enforced here. ``` In many cases, the re-enabling comment incorrectly included `disable` instead of `enable` (as shown below), which essentially keeps the `max-line-length` **disabled** for the rest of the file: ```js // Max line length enforced here. /* tslint:disable:max-line-length */ // Max line length NOT enforced here. /* tslint:disable:max-line-length */ <-- INCORRECT // Max line length NOT enforced here. ``` This commit fixes these comments, so the `max-line-length` rule is properly enforced in regions that don't need longer lines.
…when unsubscribed then resubscribed to (#2318) - Also changes one AsyncSubject test that seemed to have a typo where the author intended to dispose of a subscription, but disposed of the subject itself instead *
… output function (#2319) Set context of input function to context of output function, so that it is possible to control context at call time and underlying observable is not available in input function
… via output function (#2320) Set context of input function to context of output function, so that context can be controlled at call time and underlying observable is not available in input function
test(filter): enable type inference to marble diagram
Fix logic in test for files which use hot and cold helpers but do not provide type declarations for them, so that files that do not use hot and cold helpers at all would not count as false positives.
chore(dangerfile): fix test for hot and cold usages without types
…guments Emit undefined insteady of empty array by resulting Observable, when callback function is called without success parameters. Closes #2254
In resulting Observable emit undefined when callback is called without parameters, instead of emitting empty array.
test(all): enable type inference to marble diagram
Add support of the 'PATCH' request type based on the already existing 'PUT' request.
Add type signature for using forkJoin with single observable as first parameter and selector function as second parameter, so that typings would not prevent usage which is permitted and properly handled by operator. Closes #2347
Add binaryType to config object, so that it is possible to set that parameter on underlying socket before any data emits happen. Closes #2353
Return Observable when merge is called with single lower case observable, so that merge would always return Observable instance.
Accept array-like as a result to subscribe, so that Observable.from and operators using subscribeToResult have identical behaviour.
…event operators from leaking ChildSubscriptions. (#2360) The addition of ChildSubscription to fix #2244 accidentally introduced a different memory leak. Most operators that add and remove inner Subscriptions store the inner Subscriber instance, not the value returned by Subscription#add. When they try to remove the inner Subscription manually, nothing is removed, because the ChildSubscription wrapper instance is the one added to the subscriptions list. Fixes #2355
It's 5.5mb that people installing this don't need :)
chore(npmignore): ignore coverage report data
fix(subscribeToResult): accept array-like as result
feat(AjaxObservable) : support 'PATCH' request type
…le-input fix(merge): return Observable when called with single lowerCaseO
feat(webSocket): Add binaryType to config object
…ition fix(forkJoin): add type signature for single observable with selector
chore(danger): update dangerfile to validate commit message
…-arguments fix(bindNodeCallback): emit undefined when callback has no success ar…
…ments fix(bindCallback): emit undefined when callback is without arguments
chore(*): correctly scope disabled `max-line-length` tslint rule
fix(mergeAll): introduce variant support <T, R> for mergeMap
…descriptions Add ObservableInput and SubscribableOrPromise interface descriptions, as well as link these interfaces in type descriptions of operators, so that users always know what kind of parameters they can pass to used methods.
Adds new parameter in windowTime operator to control how much values given window can emit. Closes #1301
feat(windowTime): maxWindowSize parameter in windowTime operator
docs(ObservableInput): add ObservableInput and SubscribableOrPromise descriptions
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring
nextbranch up to date