Issue 110 - Animated tile IDs, and nullptr returned by tileset->getTile(tileId), local vs global #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SSBMTonberry
approved these changes
Dec 25, 2023
There was a problem hiding this comment.
@twje : Looks great! Thank you very much for your contribution! 🙏
This was referenced Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In a tileset, the IDs of tiles are local, which allows them to reference one another within the same tileset, for example, animation frames. At the moment, missing tiles are being assigned a global ID for their local ID.
Solution
Amend
Tileset::generateMissingTilesand the second Tile constructor responsible for instantiating missing tiles.