Prevent ibid for categories and books #2061

nsantacruz · 2024-10-10T18:09:19Z

Description

Prevents categories and books from being caught using ibid context

adds match_templates to categories so they can be caught independently
add CategoryResolver class to match categories
use CategoryResolver on Linker to first find categories and only then look for citations.
refactor out methods relating to match templates from TitledTreeNode into interface HasMatchTemplates so it can be reused for any object that has match templates
pull out with_failures variable from RefResolver so all logic is in Linker. This helps Linker use failed categories to still search for refs.

Any additional notes go here

…dRefernceableBookNode

…wall

…tegories

nsantacruz added 13 commits October 9, 2024 14:56

feat(linker): WIP allow linker to match categories

4328e9d

refactor(linker): hide logic that calculates ref order id inside Name…

1031aef

…dRefernceableBookNode

feat(linker): try to push category catching in refresolver but hit a …

2585966

…wall

chore(linker): undo changes that included categories in RefResolver.

1924a83

refactor(linker): push with_failures logic into linker

bd1a283

feat(linker): add CategoryResolver

89c8b1c

feat(linker): return categories in LinkedDoc object

7ecaf49

docs(linker): add docs to test

5c1c6db

fix(linker): don't use ibid context for a book ref

24cfd6c

test(linker): add GPT written tests for category matcher classes

161d4c6

chore(linker): remove unneeded code now that we have category resolver

4940ee2

test(linker): add test that makes sure we aren't losing ibids from ca…

81ec9d6

…tegories

fix(linker): remove failures more consistently

4fb160a