Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent ibid for categories and books #2061

Open
wants to merge 13 commits into
base: fix-sefer-hachinukh-linker
Choose a base branch
from
Open

Prevent ibid for categories and books #2061

wants to merge 13 commits into from

Commits on Oct 9, 2024

  1. feat(linker): WIP allow linker to match categories

    @nsantacruz
    nsantacruz committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    4328e9d View commit details
    Browse the repository at this point in the history

  2. refactor(linker): hide logic that calculates ref order id inside Name… 

    …dRefernceableBookNode
    @nsantacruz
    nsantacruz committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    1031aef View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. feat(linker): try to push category catching in refresolver but hit a … 

    …wall
    @nsantacruz
    nsantacruz committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    2585966 View commit details
    Browse the repository at this point in the history

  2. chore(linker): undo changes that included categories in RefResolver.

    @nsantacruz
    nsantacruz committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    1924a83 View commit details
    Browse the repository at this point in the history

  3. refactor(linker): push with_failures logic into linker

    @nsantacruz
    nsantacruz committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    bd1a283 View commit details
    Browse the repository at this point in the history

  4. feat(linker): add CategoryResolver

    @nsantacruz
    nsantacruz committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    89c8b1c View commit details
    Browse the repository at this point in the history

  5. feat(linker): return categories in LinkedDoc object

    @nsantacruz
    nsantacruz committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    7ecaf49 View commit details
    Browse the repository at this point in the history

  6. docs(linker): add docs to test

    @nsantacruz
    nsantacruz committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    5c1c6db View commit details
    Browse the repository at this point in the history

  7. fix(linker): don't use ibid context for a book ref

    @nsantacruz
    nsantacruz committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    24cfd6c View commit details
    Browse the repository at this point in the history

  8. test(linker): add GPT written tests for category matcher classes

    @nsantacruz
    nsantacruz committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    161d4c6 View commit details
    Browse the repository at this point in the history

  9. chore(linker): remove unneeded code now that we have category resolver

    @nsantacruz
    nsantacruz committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    4940ee2 View commit details
    Browse the repository at this point in the history

  10. test(linker): add test that makes sure we aren't losing ibids from ca… 

    …tegories
    @nsantacruz
    nsantacruz committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    81ec9d6 View commit details
    Browse the repository at this point in the history

  11. fix(linker): remove failures more consistently

    @nsantacruz
    nsantacruz committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    4fb160a View commit details
    Browse the repository at this point in the history