[Zend_Ldap] php 8.1 & 8.2 compatibility fixes #333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enable ldap tests
ldap_sort got deprecated in php 7.0.0, removed in php 8.0.0 ported from laminas/laminas-ldap@35162e6 and latest version of https:/laminas/laminas-ldap/tree/2.18.x
make a mistake when use php-rector migrate phpunit 3.x -> php 9.x
|
Mr @glensc could you please review this PR? thanks |
|
please extract CI changes to separate PR, i.e 4fa6b19 commit |
hungtrinh
force-pushed
the
carry-zend-ldap-from-zf1s
branch
from
4fa6b19
to
80e07ef
Compare
|
Mr @glensc
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #317 by carrying
ldap_sortwhile keeping sort features zf1s/zf1#168