Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[zend-ldap] removes calls to ldap_sort while keeping sort features #168

Merged
merged 2 commits into from
Feb 19, 2023

Conversation

marcing
Copy link
Contributor

@marcing marcing commented Feb 15, 2023

removes calls to ldap_sort while keeping sort features

ldap_sort got deprecated in php 7.0.0, removed in php 8.0.0

ported from laminas/laminas-ldap@35162e6 and latest version of https:/laminas/laminas-ldap/tree/2.18.x

@falkenhawk falkenhawk changed the title Ported sort tests from laminas, but it does not work, pushed for testing [zend-ldap] removes ldap_sort while preserving sorting Feb 15, 2023
@marcing marcing marked this pull request as ready for review February 17, 2023 16:25
@falkenhawk falkenhawk force-pushed the fix-zend-ldap-openldap-ldap-sort branch from e451294 to faf33ea Compare February 19, 2023 09:30
@falkenhawk falkenhawk changed the title [zend-ldap] removes ldap_sort while preserving sorting [zend-ldap] removes usage of ldap_sort while preserving the sort functionality Feb 19, 2023
@falkenhawk falkenhawk force-pushed the fix-zend-ldap-openldap-ldap-sort branch from faf33ea to a60d45f Compare February 19, 2023 09:36
@falkenhawk falkenhawk changed the title [zend-ldap] removes usage of ldap_sort while preserving the sort functionality [zend-ldap] removes calls to ldap_sort while keeping sort features Feb 19, 2023
@glensc
Copy link
Contributor

glensc commented Feb 19, 2023

laminas/laminas-ldap@35162e6 link doesn't exist

@falkenhawk
Copy link
Member

laminas/laminas-ldap@35162e6 link doesn't exist

corrected link: laminas/laminas-ldap@35162e6

@falkenhawk falkenhawk force-pushed the fix-zend-ldap-openldap-ldap-sort branch from 1aed013 to bed3646 Compare February 19, 2023 19:38
@falkenhawk falkenhawk merged commit 050c989 into fix-zend-ldap-openldap Feb 19, 2023
@falkenhawk falkenhawk deleted the fix-zend-ldap-openldap-ldap-sort branch February 19, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants