Check format with prettier before build
#4567
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saberduck
reviewed
Feb 12, 2024
.cirrus.yml
Outdated
| @@ -116,6 +116,8 @@ build_task: | |||
| <<: *NPMRC_SCRIPT_DEFINITION | |||
| build_and_deploy_script: | |||
| - source cirrus-env BUILD | |||
| - npm run bbf | |||
There was a problem hiding this comment.
why do we need to run the build before?
There was a problem hiding this comment.
also I would avoid using shortcut in CI script, we can "afford" to have a long name here for clarity
There was a problem hiding this comment.
true, we don't... I will replace by npm ci
saberduck
reviewed
Feb 12, 2024
.cirrus.yml
Outdated
| @@ -116,6 +116,8 @@ build_task: | |||
| <<: *NPMRC_SCRIPT_DEFINITION | |||
| build_and_deploy_script: | |||
| - source cirrus-env BUILD | |||
| - npm ci | |||
| - npx prettier --list-different . | |||
There was a problem hiding this comment.
why removing check-format? imo I would prefer to be consistent and only use package.json scripts here
There was a problem hiding this comment.
that's what I understood by:
also I would avoid using shortcut in CI script, we can "afford" to have a long name here for clarity
|
saberduck
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now, we were formatting the source code during build task, so we were not able to detect unformatted code. This adds back the format check before building the plugin
Fixes #4465