Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check format with prettier before build #4567

Merged
merged 6 commits into from
Feb 13, 2024
Merged

Check format with prettier before build #4567

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3168378
check-format before build
vdiez Feb 12, 2024
f781df5
install dependencies before checks
vdiez Feb 12, 2024
d7ef097
install dependencies before checks
vdiez Feb 12, 2024
5fb04ba
no need for its own npm script
vdiez Feb 12, 2024
d8d6c66
fix prettier run
vdiez Feb 12, 2024
b9a0c4e
revert changes
vdiez Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .cirrus.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,8 @@
<<: *NPMRC_SCRIPT_DEFINITION
build_and_deploy_script:
- source cirrus-env BUILD
- npm ci
- npx prettier --list-different .
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why removing check-format? imo I would prefer to be consistent and only use package.json scripts here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's what I understood by:

also I would avoid using shortcut in CI script, we can "afford" to have a long name here for clarity

- npm run build
- regular_mvn_build_deploy_analyze -Dmaven.test.skip=true -Dmaven.install.skip=true -Dsonar.skip=true
cleanup_before_cache_script: cleanup_maven_repository
Expand Down Expand Up @@ -302,7 +304,7 @@
diff_artifacts:
path: '**/target/actual/**/*'

promote_task:

Check warning on line 307 in .cirrus.yml

View check run for this annotation

Cirrus CI / Build Parsing Results

.cirrus.yml#L307 

task "promote" depends on task "ws_scan", but their only_if conditions are different

Check warning on line 307 in .cirrus.yml

View check run for this annotation

Cirrus CI / Build Parsing Results

.cirrus.yml#L307 

task "promote" depends on task "ws_scan", but their only_if conditions are different

Check warning on line 307 in .cirrus.yml

View check run for this annotation

Cirrus CI / Build Parsing Results

.cirrus.yml#L307 

task "promote" depends on task "ws_scan", but their only_if conditions are different

Check warning on line 307 in .cirrus.yml

View check run for this annotation

Cirrus CI / Build Parsing Results

.cirrus.yml#L307 

task "promote" depends on task "ws_scan", but their only_if conditions are different

Check warning on line 307 in .cirrus.yml

View check run for this annotation

Cirrus CI / Build Parsing Results

.cirrus.yml#L307 

task "promote" depends on task "ws_scan", but their only_if conditions are different

Check warning on line 307 in .cirrus.yml

View check run for this annotation

Cirrus CI / Build Parsing Results

.cirrus.yml#L307 

task "promote" depends on task "ws_scan", but their only_if conditions are different
depends_on:
- ws_scan
- build_win
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"bridge:compile": "tsc -b packages profiling",
"bridge:test": "jest --maxWorkers=40% --coverage --testPathIgnorePatterns=/packages/ruling/tests/",
"bridge:build": "npm run bridge:build:fast && npm run bridge:test",
"bridge:build:fast": "npm ci && npm run format && npm run _:bridge:clear && npm run bridge:compile",
"bridge:build:fast": "npm ci && npm run _:bridge:clear && npm run bridge:compile",
"bbf": "npm run bridge:build:fast",
"plugin:build-no-bridge": "mvn install",
"plugin:build:fast": "npm run plugin:build-no-bridge -- -DskipTests",
Expand Down