BED-4768 feat: add login handler for OIDC #897
+194
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistahj67
added
work in progress
mistahj67
commented
Oct 4, 2024
Comment on lines
61
to
82
| func (s *BloodhoundDB) GetSSOProviderBySlug(ctx context.Context, slug string) (model.SSOProvider, error) { | ||
| var provider model.SSOProvider | ||
| if tx := s.db.WithContext(ctx).Raw(fmt.Sprintf("SELECT id, type, name, slug, created_at, updated_at FROM %s WHERE slug = %s;", ssoProviderTableName, slug)).Scan(&provider); tx.RowsAffected == 0 { | ||
| return provider, ErrNotFound | ||
| } | ||
|
|
||
| return provider, nil | ||
| } |
There was a problem hiding this comment.
Need to add tests for this db method
mistahj67
commented
Oct 4, 2024
Comment on lines
+58
to
+70
|
|
||
| func (s *BloodhoundDB) GetOIDCProviderBySSOProviderID(ctx context.Context, ssoProviderID int32) (model.OIDCProvider, error) { | ||
| var oidcProvider model.OIDCProvider | ||
| result := s.db.WithContext(ctx).Table(oidcProvidersTableName).Where("sso_provider_id = ?", ssoProviderID).First(&oidcProvider) | ||
| return oidcProvider, CheckError(result) | ||
| } |
There was a problem hiding this comment.
This was borrowed from #896
mistahj67
changed the title
This was referenced Oct 4, 2024
Base automatically changed from
BED-4851-oidc-api-provider-registration-2
to
main
October 9, 2024 20:25
mistahj67
force-pushed
the
BED-4768
branch
2 times, most recently
from
f275bd6
to
24e4f99
Compare
mistahj67
removed
the
work in progress
mistahj67
force-pushed
the
BED-4768
branch
2 times, most recently
from
6502197
to
b606d76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: This shouldn't be merged into BED-4851 and should wait until both #896 and #894 are merged. It was just selected as the base for easier PR review.
Add login handler for OIDC
Motivation and Context
This PR addresses: BED-4768
Why is this change required? What problem does it solve?
In order to support OIDC we need to have a generic login handler
How Has This Been Tested?
This is used in conjunction with Authentik locally to verify proper redirection occurred.
Types of changes
Checklist: