Bed 4767 feat: add callback handler for OIDC #898
+213
−115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistahj67
added
work in progress
mistahj67
commented
Oct 4, 2024
Comment on lines
+352
to
+354
| case model.OIDCProvider: | ||
| //todo connect to db provider table | ||
| break |
There was a problem hiding this comment.
This must be done once user table is properly migrated / updated to handle either a generic sso_provider_id or a second oidc_provider_id table @mvlipka
mistahj67
commented
Oct 4, 2024
cmd/api/src/model/sso_provider.go
Outdated
| @@ -27,7 +27,7 @@ const ( | |||
|
|
|||
| // SSOProvider is the common representation of an SSO provider that can be used to display high level information about that provider | |||
| type SSOProvider struct { | |||
| Type SSOProviderType `json:"type"` | |||
| Type SessionAuthProvider `json:"type"` | |||
There was a problem hiding this comment.
This likely needs to be updated to whatever was reflected in #896
3 tasks
mistahj67
removed
the
work in progress
mistahj67
force-pushed
the
BED-4768
branch
2 times, most recently
from
337562e
to
c1c9df9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Note: This shouldn't be merged into BED-4768 and should wait until the following are merged:
It was just selected as the base for easier PR review.
Add callback handler for OIDC
Motivation and Context
This PR addresses: BED-4767
Why is this change required? What problem does it solve?
In order to support OIDC we need to have a generic callback handler
How Has This Been Tested?
This is used in conjunction with Authentik locally to verify proper callback handling occurred.
Types of changes
Checklist: