New CLI Options #364
Merged
New CLI Options #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ments. # Please enter the commit message for your changes. Lines starting # with '#' will be ignored, and an empty message aborts the commit. # # interactive rebase in progress; onto 2fa8069 # Last commands done (3 commands done): # pick 7db1c77 Updates to pass pre-commit. # pick 9197e4e Bug fix and log statements. # Next commands to do (2 remaining commands): # pick f382208 Updatest to resolve conflicts with changes related to floating point headers for indexing. # pick 6961e1d Fix pre-commit linting. # You are currently rebasing branch 'main' on '2fa8069'. # # Changes to be committed: # modified: src/mdio/segy/utilities.py # modified: tests/integration/test_segy_import_export.py # # Untracked files: # .devcontainer_bck/Dockerfile # .devcontainer_bck/devcontainer.json # .devcontainer_bck/post-install.sh # .gitignore_bck # TEST.md # debugging/0__6372_PREPNODMLT.LIBRARY_2.mdio.jpg # debugging/6372_export.py # debugging/6372_ram_usage.csv # debugging/6372_ram_usage.csv_bck # debugging/Debug.md # debugging/None # debugging/docker_env/bin/Activate.ps1 # debugging/docker_env/bin/activate # debugging/docker_env/bin/activate.csh # debugging/docker_env/bin/activate.fish # debugging/docker_env/bin/dask # debugging/docker_env/bin/dask-scheduler # debugging/docker_env/bin/dask-ssh # debugging/docker_env/bin/dask-worker # debugging/docker_env/bin/doesitcache # debugging/docker_env/bin/dul-receive-pack # debugging/docker_env/bin/dul-upload-pack # debugging/docker_env/bin/dulwich # debugging/docker_env/bin/easy_install # debugging/docker_env/bin/easy_install-3.8 # debugging/docker_env/bin/f2py # debugging/docker_env/bin/f2py3 # debugging/docker_env/bin/f2py3.8 # debugging/docker_env/bin/fonttools # debugging/docker_env/bin/jsonschema # debugging/docker_env/bin/keyring # debugging/docker_env/bin/pip # debugging/docker_env/bin/pip3 # debugging/docker_env/bin/pip3.8 # debugging/docker_env/bin/pkginfo # debugging/docker_env/bin/poetry # debugging/docker_env/bin/py-spy # debugging/docker_env/bin/pyftmerge # debugging/docker_env/bin/pyftsubset # debugging/docker_env/bin/pyproject-build # debugging/docker_env/bin/python # debugging/docker_env/bin/python3 # debugging/docker_env/bin/ttx # debugging/docker_env/bin/virtualenv # debugging/docker_env/lib64 # debugging/docker_env/share/man/man1/ttx.1 # debugging/docker_env/share/python-wheels/CacheControl-0.12.6-py2.py3-none-any.whl # debugging/docker_env/share/python-wheels/appdirs-1.4.3-py2.py3-none-any.whl # debugging/docker_env/share/python-wheels/certifi-2019.11.28-py2.py3-none-any.whl # debugging/docker_env/share/python-wheels/chardet-3.0.4-py2.py3-none-any.whl # debugging/docker_env/share/python-wheels/colorama-0.4.3-py2.py3-none-any.whl # debugging/docker_env/share/python-wheels/contextlib2-0.6.0-py2.py3-none-any.whl # debugging/docker_env/share/python-wheels/distlib-0.3.0-py2.py3-none-any.whl # debugging/docker_env/share/python-wheels/distro-1.4.0-py2.py3-none-any.whl # debugging/docker_env/share/python-wheels/html5lib-1.0.1-py2.py3-none-any.whl # debugging/docker_env/share/python-wheels/idna-2.8-py2.py3-none-any.whl # debugging/docker_env/share/python-wheels/ipaddr-2.2.0-py2.py3-none-any.whl # debugging/docker_env/share/python-wheels/lockfile-0.12.2-py2.py3-none-any.whl # debugging/docker_env/share/python-wheels/msgpack-0.6.2-py2.py3-none-any.whl # debugging/docker_env/share/python-wheels/packaging-20.3-py2.py3-none-any.whl # debugging/docker_env/share/python-wheels/pep517-0.8.2-py2.py3-none-any.whl # debugging/docker_env/share/python-wheels/pip-20.0.2-py2.py3-none-any.whl # debugging/docker_env/share/python-wheels/pkg_resources-0.0.0-py2.py3-none-any.whl # debugging/docker_env/share/python-wheels/progress-1.5-py2.py3-none-any.whl # debugging/docker_env/share/python-wheels/pyparsing-2.4.6-py2.py3-none-any.whl # debugging/docker_env/share/python-wheels/requests-2.22.0-py2.py3-none-any.whl # debugging/docker_env/share/python-wheels/retrying-1.3.3-py2.py3-none-any.whl # debugging/docker_env/share/python-wheels/setuptools-44.0.0-py2.py3-none-any.whl # deb
Updated the segy.py file to import specific functions from click, rather than the entire module. The command decorator's function signatures and calls are also updated. This is to improve specificity and reduce unnecessary overhead. Additionally, modified the way command line arguments are passed in test_main.py as per the refactored changes in the main function.
The import statement for 'MDIOReader' in the copy.py file has been moved to a more appropriate position. This change aims to maximize importing efficiency by having the import statement closer to where the imported module is being used.
The MDIO info command is refactored to enhance code readability and maintenance. The new structure involves separate functions for 'cast_stats', 'parse_grid' and 'pretty_print' to each perform distinct tasks. This improves the clear segregation of tasks and ease of future modifications.
The documentation for the mdio commands has been updated to reflect changes in the command syntax. Parameters for input and output files are now required positional arguments, rather than options, enhancing the clarity and readability of the commands.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues #230
Had to refactor due to recent CLI changes in
main. Also added the following to @markspec's work:infocommand to componentsfastentrypoints[CLI much faster now]overwriteto flag [BREAKING]